From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sog-mx-2.v43.ch3.sourceforge.com ([172.29.43.192] helo=mx.sourceforge.net) by sfs-ml-3.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1Qe1vo-00022l-Nt for user-mode-linux-devel@lists.sourceforge.net; Tue, 05 Jul 2011 09:28:36 +0000 Received: from a.ns.miles-group.at ([95.130.255.143] helo=radon.swed.at) by sog-mx-2.v43.ch3.sourceforge.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.76) id 1Qe1vn-0006i9-Bs for user-mode-linux-devel@lists.sourceforge.net; Tue, 05 Jul 2011 09:28:36 +0000 From: Richard Weinberger Date: Tue, 5 Jul 2011 11:28:24 +0200 References: <1309821341.4527.5.camel@vitaliy-Vostro-1400> In-Reply-To: <1309821341.4527.5.camel@vitaliy-Vostro-1400> MIME-Version: 1.0 Message-Id: <201107051128.25262.richard@nod.at> List-Id: The user-mode Linux development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: user-mode-linux-devel-bounces@lists.sourceforge.net Subject: Re: [uml-devel] [PATCH 1/4] uml: cow_user.c warning corrections To: vitalivanov@gmail.com Cc: Jeff Dike , Linus Torvalds , "akpm@linux-foundation.org" , user-mode-linux-devel@lists.sourceforge.net, lkml QW0gRGllbnN0YWcgMDUgSnVsaSAyMDExLCAwMToxNTo0MSBzY2hyaWViIFZpdGFsaXkgSXZhbm92 Ogo+IEZyb20gNjIwMWQzZTg2MmZjYTg2NzBiMjA2MzM4ZGM5MDMwM2VhMGFjYzc3ZCBNb24gU2Vw IDE3IDAwOjAwOjAwIDIwMDEKPiBGcm9tOiBWaXRhbGl5IEl2YW5vdiA8dml0YWxpdmFub3ZAZ21h aWwuY29tPgo+IERhdGU6IFR1ZSwgNSBKdWwgMjAxMSAwMTo1Nzo1MSArMDMwMAo+IFN1YmplY3Q6 IFtQQVRDSCAxLzRdIHVtbDogY293X3VzZXIuYyB3YXJuaW5nIGNvcnJlY3Rpb25zCj4gTUlNRS1W ZXJzaW9uOiAxLjAKPiBDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNoYXJzZXQ9VVRGLTgKPiBD b250ZW50LVRyYW5zZmVyLUVuY29kaW5nOiA4Yml0Cj4gCj4gYXJjaC91bS9kcml2ZXJzL2Nvd191 c2VyLmM6IEluIGZ1bmN0aW9uIOKAmGFic29sdXRpemXigJk6Cj4gYXJjaC91bS9kcml2ZXJzL2Nv d191c2VyLmM6MTg5Ojc6IHdhcm5pbmc6IGlnbm9yaW5nIHJldHVybiB2YWx1ZSBvZgo+IOKAmGNo ZGly4oCZLCBkZWNsYXJlZCB3aXRoIGF0dHJpYnV0ZSB3YXJuX3VudXNlZF9yZXN1bHQKCldoYXQg Y29tcGlsZXIgZmxhZ3MgYXJlIHlvdSB1c2luZz8KVXNpbmcgdGhlIGRlZmF1bHQgc2V0dGluZ3Mg dGhpcyB3YXJuaW5nIGRvZXMgbm90IHNob3cgdXAuCk1vc3Qgb2YgdGhlICJpZ25vcmluZyByZXR1 cm4gdmFsdWUiIGFyZSB0b3RhbGx5IHVzZWxlc3MuCgo+IFNpZ25lZC1vZmYtYnk6IFZpdGFsaXkg SXZhbm92IDx2aXRhbGl2YW5vdkBnbWFpbC5jb20+Cj4gLS0tCj4gIGFyY2gvdW0vZHJpdmVycy9j b3dfdXNlci5jIHwgICAgNiArKysrKy0KPiAgMSBmaWxlcyBjaGFuZ2VkLCA1IGluc2VydGlvbnMo KyksIDEgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2FyY2gvdW0vZHJpdmVycy9jb3df dXNlci5jIGIvYXJjaC91bS9kcml2ZXJzL2Nvd191c2VyLmMKPiBpbmRleCA5M2YyMjdhLi45Y2Ji NDI2IDEwMDY0NAo+IC0tLSBhL2FyY2gvdW0vZHJpdmVycy9jb3dfdXNlci5jCj4gKysrIGIvYXJj aC91bS9kcml2ZXJzL2Nvd191c2VyLmMKPiBAQCAtMTg2LDcgKzE4NiwxMSBAQCBzdGF0aWMgaW50 IGFic29sdXRpemUoY2hhciAqdG8sIGludCBzaXplLCBjaGFyICpmcm9tKQo+ICAJCXN0cmNhdCh0 bywgIi8iKTsKPiAgCQlzdHJjYXQodG8sIGZyb20pOwo+ICAJfQo+IC0JY2hkaXIoc2F2ZV9jd2Qp Owo+ICsJaWYgKGNoZGlyKHNhdmVfY3dkKSkgewo+ICsJCWNvd19wcmludGYoImFic29sdXRpemUg OiBDYW4ndCBjZCB0byAnJXMnIC0gIgo+ICsJCQkgICAiZXJybm8gPSAlZFxuIiwgc2F2ZV9jd2Qs IGVycm5vKTsKPiArCQlyZXR1cm4gLTE7Cj4gKwl9CgpJIGRvbid0IHRoaW5rIHRoYXQgdGhpcyBj aGVjayBpcyBuZWVkZWQgbm9yIGNoZGlyKCkgdG8gc2F2ZV9jd2QgY2FuIGZhaWwuCkJlY2F1c2Ug d2Ugb2J0YWluIGl0IGJ5IGNhbGxpbmcgZ2V0Y3dkKCkgYW5kIG5ldmVyIGNoYW5nZSBpdC4uLgoK VGhhbmtzLAovL3JpY2hhcmQKCi0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQpBbGwgb2YgdGhlIGRhdGEg Z2VuZXJhdGVkIGluIHlvdXIgSVQgaW5mcmFzdHJ1Y3R1cmUgaXMgc2VyaW91c2x5IHZhbHVhYmxl LgpXaHk/IEl0IGNvbnRhaW5zIGEgZGVmaW5pdGl2ZSByZWNvcmQgb2YgYXBwbGljYXRpb24gcGVy Zm9ybWFuY2UsIHNlY3VyaXR5IAp0aHJlYXRzLCBmcmF1ZHVsZW50IGFjdGl2aXR5LCBhbmQgbW9y ZS4gU3BsdW5rIHRha2VzIHRoaXMgZGF0YSBhbmQgbWFrZXMgCnNlbnNlIG9mIGl0LiBJVCBzZW5z ZS4gQW5kIGNvbW1vbiBzZW5zZS4KaHR0cDovL3Auc2YubmV0L3NmdS9zcGx1bmstZDJkLWMyCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClVzZXItbW9kZS1s aW51eC1kZXZlbCBtYWlsaW5nIGxpc3QKVXNlci1tb2RlLWxpbnV4LWRldmVsQGxpc3RzLnNvdXJj ZWZvcmdlLm5ldApodHRwczovL2xpc3RzLnNvdXJjZWZvcmdlLm5ldC9saXN0cy9saXN0aW5mby91 c2VyLW1vZGUtbGludXgtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754783Ab1GEJ2b (ORCPT ); Tue, 5 Jul 2011 05:28:31 -0400 Received: from a.ns.miles-group.at ([95.130.255.143]:44866 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754467Ab1GEJ2a convert rfc822-to-8bit (ORCPT ); Tue, 5 Jul 2011 05:28:30 -0400 From: Richard Weinberger To: vitalivanov@gmail.com Subject: Re: [PATCH 1/4] uml: cow_user.c warning corrections Date: Tue, 5 Jul 2011 11:28:24 +0200 User-Agent: KMail/1.13.7 (Linux/2.6.37.6-0.5-desktop; KDE/4.6.4; x86_64; ; ) Cc: Jeff Dike , Linus Torvalds , "akpm@linux-foundation.org" , user-mode-linux-devel@lists.sourceforge.net, lkml References: <1309821341.4527.5.camel@vitaliy-Vostro-1400> In-Reply-To: <1309821341.4527.5.camel@vitaliy-Vostro-1400> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 8BIT Message-Id: <201107051128.25262.richard@nod.at> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Dienstag 05 Juli 2011, 01:15:41 schrieb Vitaliy Ivanov: > From 6201d3e862fca8670b206338dc90303ea0acc77d Mon Sep 17 00:00:00 2001 > From: Vitaliy Ivanov > Date: Tue, 5 Jul 2011 01:57:51 +0300 > Subject: [PATCH 1/4] uml: cow_user.c warning corrections > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > arch/um/drivers/cow_user.c: In function ‘absolutize’: > arch/um/drivers/cow_user.c:189:7: warning: ignoring return value of > ‘chdir’, declared with attribute warn_unused_result What compiler flags are you using? Using the default settings this warning does not show up. Most of the "ignoring return value" are totally useless. > Signed-off-by: Vitaliy Ivanov > --- > arch/um/drivers/cow_user.c | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/arch/um/drivers/cow_user.c b/arch/um/drivers/cow_user.c > index 93f227a..9cbb426 100644 > --- a/arch/um/drivers/cow_user.c > +++ b/arch/um/drivers/cow_user.c > @@ -186,7 +186,11 @@ static int absolutize(char *to, int size, char *from) > strcat(to, "/"); > strcat(to, from); > } > - chdir(save_cwd); > + if (chdir(save_cwd)) { > + cow_printf("absolutize : Can't cd to '%s' - " > + "errno = %d\n", save_cwd, errno); > + return -1; > + } I don't think that this check is needed nor chdir() to save_cwd can fail. Because we obtain it by calling getcwd() and never change it... Thanks, //richard