From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Richard Weinberger Date: Tue, 5 Jul 2011 13:40:04 +0200 References: <1309821341.4527.5.camel@vitaliy-Vostro-1400> <201107051331.15504.richard@nod.at> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <201107051340.04949.richard@nod.at> Subject: Re: [PATCH 1/4] uml: cow_user.c warning corrections To: Geert Uytterhoeven Cc: Vitaliy Ivanov , Jeff Dike , Linus Torvalds , "akpm@linux-foundation.org" , user-mode-linux-devel@lists.sourceforge.net, lkml List-ID: Am Dienstag 05 Juli 2011, 13:38:05 schrieb Geert Uytterhoeven: > On Tue, Jul 5, 2011 at 13:31, Richard Weinberger wrote: > > Am Dienstag 05 Juli 2011, 13:10:34 schrieb Vitaliy Ivanov: > >> On Tue, Jul 5, 2011 at 12:28 PM, Richard Weinberger w= rote: > >> > Am Dienstag 05 Juli 2011, 01:15:41 schrieb Vitaliy Ivanov: > >> >> From 6201d3e862fca8670b206338dc90303ea0acc77d Mon Sep 17 00:00:00 > >> >> 2001 From: Vitaliy Ivanov > >> >> Date: Tue, 5 Jul 2011 01:57:51 +0300 > >> >> Subject: [PATCH 1/4] uml: cow_user.c warning corrections > >> >> MIME-Version: 1.0 > >> >> Content-Type: text/plain; charset=3DUTF-8 > >> >> Content-Transfer-Encoding: 8bit > >> >>=20 > >> >> arch/um/drivers/cow_user.c: In function =E2=80=98absolutize=E2=80= =99: > >> >> arch/um/drivers/cow_user.c:189:7: warning: ignoring return value of > >> >> =E2=80=98chdir=E2=80=99, declared with attribute warn_unused_result > >> >=20 > >> > What compiler flags are you using? > >> > Using the default settings this warning does not show up. > >> > Most of the "ignoring return value" are totally useless. > >>=20 > >> chdir is defined with warn_unused_result attribute and my gcc on > >> Ubuntu 11.04 issues warnings. > >> I don't use any additional flags on compiling UML. > >=20 > > Ah, because of -D_FORTIFY_SOURCE=3D2, right? > > Then your patches makes sense. >=20 > I also saw it, with gcc version 4.4.3 (Ubuntu 4.4.3-4ubuntu5). > I never used FORTIFY_SOURCE. > Ubuntu uses FORTIFY_SOURCE per default. Thanks, //richard