From: "Michael S. Tsirkin" <mst@redhat.com>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: Kevin Wolf <kwolf@redhat.com>, Blue Swirl <blauwirbel@gmail.com>,
Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH] pci: add standard bridge device
Date: Tue, 5 Jul 2011 16:43:11 +0300 [thread overview]
Message-ID: <20110705134311.GA27541@redhat.com> (raw)
In-Reply-To: <20110705132936.GA25836@valinux.co.jp>
On Tue, Jul 05, 2011 at 10:29:36PM +0900, Isaku Yamahata wrote:
> On Mon, Jul 04, 2011 at 12:43:59PM +0300, Michael S. Tsirkin wrote:
> > +/* Mapping mandated by PCI-to-PCI Bridge architecture specification,
> > + * revision 1.2 */
> > +/* Table 9-1: Interrupt Binding for Devices Behind a Bridge */
> > +static int pci_bridge_dev_map_irq_fn(PCIDevice *dev, int irq_num)
> > +{
> > + return (irq_num + PCI_SLOT(dev->devfn) + irq_num) % PCI_NUM_PINS;
> ^^^^^^^ ^^^^^^^
> Typo. There are 2 irq_num.
Good catch, thanks.
> --
> yamahata
next prev parent reply other threads:[~2011-07-05 13:42 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-04 9:43 [Qemu-devel] [PATCH] pci: add standard bridge device Michael S. Tsirkin
2011-07-05 13:29 ` Isaku Yamahata
2011-07-05 13:43 ` Michael S. Tsirkin [this message]
2011-08-17 8:37 ` Wen Congyang
2011-08-18 3:22 ` Wen Congyang
2011-08-18 15:15 ` Avi Kivity
2011-08-19 5:12 ` Wen Congyang
2011-08-19 15:26 ` Avi Kivity
2011-08-22 3:13 ` Wen Congyang
2011-08-22 6:23 ` Avi Kivity
2011-09-02 1:32 ` Wen Congyang
2011-09-02 2:56 ` Wen Congyang
2011-09-04 8:25 ` Avi Kivity
2011-09-06 3:06 ` Wen Congyang
2011-09-06 7:45 ` Avi Kivity
2011-09-07 4:39 ` Wen Congyang
2011-09-07 11:52 ` Michael S. Tsirkin
2011-09-08 6:15 ` Wen Congyang
2011-09-08 7:26 ` Wen Congyang
2011-09-08 9:43 ` Gerd Hoffmann
2011-09-08 9:58 ` Wen Congyang
2011-09-08 10:42 ` Michael S. Tsirkin
2011-09-08 11:03 ` Wen Congyang
2011-09-08 11:13 ` Michael S. Tsirkin
2011-09-09 6:43 ` Wen Congyang
2011-09-09 7:12 ` Michael S. Tsirkin
2011-09-09 7:24 ` Wen Congyang
2011-09-09 7:34 ` Michael S. Tsirkin
2011-09-09 7:35 ` Wen Congyang
2011-08-26 9:43 ` Michael S. Tsirkin
2011-08-28 7:50 ` Avi Kivity
2011-08-28 11:41 ` Michael S. Tsirkin
2011-08-28 13:10 ` Avi Kivity
2011-08-28 13:42 ` Michael S. Tsirkin
2011-08-28 13:53 ` Avi Kivity
2011-09-04 12:30 ` Michael S. Tsirkin
2011-09-04 12:40 ` Avi Kivity
2011-09-04 13:01 ` Michael S. Tsirkin
2011-09-04 13:05 ` Avi Kivity
2011-09-04 13:09 ` Avi Kivity
2011-09-04 13:41 ` Michael S. Tsirkin
2011-09-04 13:55 ` Avi Kivity
2011-09-04 14:21 ` Michael S. Tsirkin
2011-09-04 14:36 ` Avi Kivity
2011-09-04 14:54 ` Michael S. Tsirkin
2011-09-04 15:14 ` Avi Kivity
2011-09-04 15:24 ` Michael S. Tsirkin
2011-09-04 15:37 ` Avi Kivity
2011-09-04 15:45 ` Michael S. Tsirkin
2011-09-04 15:46 ` Avi Kivity
2011-09-04 16:19 ` Michael S. Tsirkin
2011-09-04 16:22 ` Avi Kivity
2011-09-04 17:03 ` Michael S. Tsirkin
2011-09-05 5:36 ` Avi Kivity
2011-09-04 15:26 ` Michael S. Tsirkin
2011-09-04 15:42 ` Avi Kivity
2011-09-04 15:46 ` Michael S. Tsirkin
2011-09-04 15:49 ` Avi Kivity
2011-09-04 16:20 ` Michael S. Tsirkin
2011-08-26 9:57 ` Michael S. Tsirkin
2011-09-04 17:11 ` Michael S. Tsirkin
2011-09-05 8:17 ` Markus Armbruster
2011-09-05 9:38 ` Michael S. Tsirkin
2011-09-05 9:53 ` Gerd Hoffmann
2011-09-05 11:40 ` Michael S. Tsirkin
2011-09-06 9:18 ` Markus Armbruster
[not found] ` <4E801927.8020708@cn.fujitsu.com>
[not found] ` <20110926070824.GB5860@redhat.com>
[not found] ` <4EAF4AFD.6040102@cn.fujitsu.com>
[not found] ` <20111101084439.GA11958@redhat.com>
2011-11-01 8:49 ` Wen Congyang
2011-11-01 11:48 ` Michael S. Tsirkin
2011-11-02 1:00 ` Wen Congyang
2011-11-02 2:15 ` Isaku Yamahata
2011-11-02 2:38 ` Wen Congyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110705134311.GA27541@redhat.com \
--to=mst@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.