From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Wed, 6 Jul 2011 09:40:34 +0200 Subject: [PATCH v2] ARM: CSR: Adding CSR SiRFprimaII board support In-Reply-To: References: <1309231954-23260-1-git-send-email-bs14@csr.com> <20110706062838.GI9978@ponder.secretlab.ca> Message-ID: <201107060940.34452.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wednesday 06 July 2011 09:03:45 Barry Song wrote: > but it seems we will still add "sirf,alsta6-intc" in intc driver if > that really happen in the future. in my understanding, drivers should > explicitly claim all chips or ip cores they can support. I don't think there is a need for that. I'd only add the second one if there is a need in the driver to tell the difference. In that case, you can add a data field to the device_id and use that for making decisions in the driver. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v2] ARM: CSR: Adding CSR SiRFprimaII board support Date: Wed, 6 Jul 2011 09:40:34 +0200 Message-ID: <201107060940.34452.arnd@arndb.de> References: <1309231954-23260-1-git-send-email-bs14@csr.com> <20110706062838.GI9978@ponder.secretlab.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Barry Song <21cnbao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Cc: linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, workgroup.linux-kQvG35nSl+M@public.gmane.org, weizeng.he-kQvG35nSl+M@public.gmane.org, tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Wednesday 06 July 2011 09:03:45 Barry Song wrote: > but it seems we will still add "sirf,alsta6-intc" in intc driver if > that really happen in the future. in my understanding, drivers should > explicitly claim all chips or ip cores they can support. I don't think there is a need for that. I'd only add the second one if there is a need in the driver to tell the difference. In that case, you can add a data field to the device_id and use that for making decisions in the driver. Arnd