From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753507Ab1GHBwj (ORCPT ); Thu, 7 Jul 2011 21:52:39 -0400 Received: from acsinet14.oracle.com ([141.146.126.236]:57527 "EHLO acsinet14.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753224Ab1GHBwi (ORCPT ); Thu, 7 Jul 2011 21:52:38 -0400 X-Greylist: delayed 1390 seconds by postgrey-1.27 at vger.kernel.org; Thu, 07 Jul 2011 21:52:38 EDT Date: Fri, 8 Jul 2011 09:26:49 +0800 From: Wengang Wang To: Greg KH Cc: Wengang Wang , stable@kernel.org, greg.marsden@oracle.com, joe.jin@oracle.com, linux-kernel@vger.kernel.org Subject: Re: [stable] [PATCH] mm: prevent concurrent unmap_mapping_range() on the same inode --to stable Message-ID: <20110708012649.GA3013@laptop.jp.oracle.com> References: <201106240702.p5O72bkH003998@acsmt358.oracle.com> <20110707235547.GA1119@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110707235547.GA1119@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: rtcsinet22.oracle.com [66.248.204.30] X-CT-RefId: str=0001.0A090201.4E165CF9.009A:SCFSTAT5015188,ss=1,re=-4.000,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, greg k-h On 11-07-07 16:55, Greg KH wrote: > On Fri, Jun 24, 2011 at 03:02:08PM +0800, Wengang Wang wrote: > > mainline commit 2aa15890f3c191326678f1bd68af61ec6b8753ec > > > > mm: prevent concurrent unmap_mapping_range() on the same inode > > > > Michael Leun reported that running parallel opens on a fuse filesystem > > can trigger a "kernel BUG at mm/truncate.c:475" > > > > Gurudas Pai reported the same bug on NFS. > > > > The reason is, unmap_mapping_range() is not prepared for more than > > one concurrent invocation per inode. For example: > > > > thread1: going through a big range, stops in the middle of a vma and > > stores the restart address in vm_truncate_count. > > > > thread2: comes in with a small (e.g. single page) unmap request on > > the same vma, somewhere before restart_address, finds that the > > vma was already unmapped up to the restart address and happily > > returns without doing anything. > > > > Another scenario would be two big unmap requests, both having to > > restart the unmapping and each one setting vm_truncate_count to its > > own value. This could go on forever without any of them being able to > > finish. > > > > Truncate and hole punching already serialize with i_mutex. Other > > callers of unmap_mapping_range() do not, and it's difficult to get > > i_mutex protection for all callers. In particular ->d_revalidate(), > > which calls invalidate_inode_pages2_range() in fuse, may be called > > with or without i_mutex. > > > > This patch adds a new mutex to 'struct address_space' to prevent > > running multiple concurrent unmap_mapping_range() on the same mapping. > > > > [ We'll hopefully get rid of all this with the upcoming mm > > preemptibility series by Peter Zijlstra, the "mm: Remove i_mmap_mutex > > lockbreak" patch in particular. But that is for 2.6.39 ] > > > > > > Adding this patch causes Kabi breakage. > > > > Signed-off-by: Miklos Szeredi > > Reported-by: Michael Leun > > Reported-by: Gurudas Pai > > Tested-by: Gurudas Pai > > Acked-by: Hugh Dickins > > Cc: stable@kernel.org > > Signed-off-by: Linus Torvalds > > Signed-off-by: Wengang Wang > > As this patch showed up in 2.6.39, I'm confused as to what you wanted me > to do with it, so I've dropped it from my queue. I hope this committed in 2.6.32 stable tree please. regards, wengang.