All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/2] kernel.bbclass: handle embedding of initramfs images
Date: Fri, 8 Jul 2011 09:36:04 +0100	[thread overview]
Message-ID: <201107080936.04874.paul.eggleton@linux.intel.com> (raw)
In-Reply-To: <BAE51988-281C-4135-A796-75ABE2667937@gmail.com>

On Friday 08 July 2011 01:53:38 Khem Raj wrote:
> > On Fri, Jul 8, 2011 at 1:11 AM, Andrea Adami <andrea.adami@gmail.com> > >> 
> >> +    image = bb.data.getVar('INITRAMFS_IMAGE', d, True)
> >> +    if image != '' and image is not None:
>                         ^^^
> Is this ok ?

Probably "if image:" would be better.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre



  reply	other threads:[~2011-07-08  8:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-07 23:11 [PATCH 0/2] Add support for initramfs Andrea Adami
2011-07-07 23:11 ` [PATCH 1/2] kernel.bbclass: handle embedding of initramfs images Andrea Adami
2011-07-08  0:00   ` Andrea Adami
2011-07-08  0:53     ` Khem Raj
2011-07-08  8:36       ` Paul Eggleton [this message]
2011-07-08 15:38   ` Darren Hart
2011-07-08 16:00     ` Koen Kooi
2011-07-08 21:44     ` Andrea Adami
2011-07-09 19:25       ` Andrea Adami
2011-07-07 23:11 ` [PATCH 2/2] image_types.bbclass: support xz compressed initramfs.cpio and tarballs Andrea Adami

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201107080936.04874.paul.eggleton@linux.intel.com \
    --to=paul.eggleton@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.