Re: Re: [PATCH 1 of 3] xen: Automatically find serial port on PCI/PCIe and AMT devices

[Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>]

On Fri, Jul 08, 2011 at 08:04:40AM +0100, Jan Beulich wrote:
> >>> Konrad Rzeszutek Wilk  07/07/11 6:36 PM >>>
> >On Thu, Jul 07, 2011 at 04:56:23PM +0100, Jan Beulich wrote:
> >> >>> On 07.07.11 at 15:59, Konrad Rzeszutek Wilk  wrote:
> >> > +              bar0 = pci_conf_read32 (b, d, f, PCI_BASE_ADDRESS_0);
> >> 
> >> Why would a serial port only be allowed to be on the port specified
> >> with BAR0? E.g. if you have a serial card with multiple ports, multiple
> >> BARs could be candidates.
> >> 
> >> Also, why would the first one found be it?
> >
> >Because that is usually COM1. You can still do com1=115200,8n1,magic
> >com2=115200,8n1,0xd900,0 to have both of them available.
> 
> But the handling here is being called for com1= and com2=
> equally. For something not just for somebody's special purposes,
> the index from the calling function should minimally be passed
> (and the BAR to look at adjusted accordingly).

<nods> Will prep a patch.
> 
> Also I wonder why the token is "magic" rather than, say, "pci".

No idea, but 'pci' sounds much better. Will prep up a patch for that.
> 
> Jan
>