From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: Greg KH <greg@kroah.com>,
Dimitris Papastamos <dp@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@ti.com>, Samuel Oritz <sameo@linux.intel.com>,
Graeme Gregory <gg@slimlogic.co.uk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] regmap: Add I2C bus support
Date: Sat, 9 Jul 2011 23:08:36 +0900 [thread overview]
Message-ID: <20110709140833.GA17655@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20110709115307.GA19804@pengutronix.de>
On Sat, Jul 09, 2011 at 01:53:07PM +0200, Wolfram Sang wrote:
> On Sat, Jul 09, 2011 at 01:50:42PM +0900, Mark Brown wrote:
> > +#include <linux/regmap.h>
> > +#include <linux/i2c.h>
> > +#include <linux/module.h>
> I second Lars-Peter with init.h here (from his first review).
Remind me of what you're talking about here?
> > + if (!i2c_check_functionality(i2c->adapter, I2C_FUNC_PROTOCOL_MANGLING))
> > + return -ENOTSUPP;
> Even more here. MANGLING is not needed for reading (and it will fail for a
> number of i2c-masters).
Huh, though I'd removed this.
next prev parent reply other threads:[~2011-07-09 14:08 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-09 4:49 [PATCH 0/4] regmap: Generic I2C and SPI register map library Mark Brown
2011-07-09 4:50 ` [PATCH 1/4] regmap: Add generic non-memory mapped register access API Mark Brown
2011-07-09 4:50 ` [PATCH 2/4] regmap: Add I2C bus support Mark Brown
2011-07-09 11:53 ` Wolfram Sang
2011-07-09 14:08 ` Mark Brown [this message]
2011-07-09 14:57 ` Wolfram Sang
2011-07-10 2:59 ` Mark Brown
2011-07-10 9:03 ` Wolfram Sang
2011-07-09 4:50 ` [PATCH 3/4] regmap: Add SPI " Mark Brown
2011-07-15 2:53 ` Grant Likely
2011-07-15 4:39 ` Mark Brown
2011-07-15 5:04 ` Grant Likely
2011-07-15 5:09 ` Mark Brown
2011-07-15 9:01 ` Jonathan Cameron
2011-07-15 18:30 ` Grant Likely
2011-07-09 4:50 ` [PATCH 4/4] regulator: Convert tps65023 to use regmap API Mark Brown
2011-07-15 2:53 ` Grant Likely
2011-07-15 4:48 ` Mark Brown
2011-07-15 18:29 ` Grant Likely
2011-07-16 1:47 ` Mark Brown
2011-07-16 2:06 ` Grant Likely
2011-07-16 2:13 ` Mark Brown
2011-07-09 5:44 ` [PATCH 1/4] regmap: Add generic non-memory mapped register access API Greg KH
2011-07-15 2:53 ` Grant Likely
2011-07-15 3:25 ` Mark Brown
2011-07-15 3:30 ` Grant Likely
-- strict thread matches above, loose matches on Subject: below --
2011-07-15 6:22 [PATCH 0/4] regmap: Generic I2C and SPI register map library Mark Brown
2011-07-15 6:23 ` [PATCH 1/4] regmap: Add generic non-memory mapped register access API Mark Brown
2011-07-15 6:23 ` [PATCH 2/4] regmap: Add I2C bus support Mark Brown
2011-07-16 2:48 [PATCH 0/4] regmap: Generic I2C and SPI register map library Mark Brown
2011-07-16 2:48 ` [PATCH 1/4] regmap: Add generic non-memory mapped register access API Mark Brown
2011-07-16 2:48 ` [PATCH 2/4] regmap: Add I2C bus support Mark Brown
2011-07-18 10:04 [PATCH 0/4] regmap: Generic I2C and SPI register map library Mark Brown
2011-07-18 10:07 ` [PATCH 1/4] regmap: Add generic non-memory mapped register access API Mark Brown
2011-07-18 10:07 ` [PATCH 2/4] regmap: Add I2C bus support Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110709140833.GA17655@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=dp@opensource.wolfsonmicro.com \
--cc=gg@slimlogic.co.uk \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=sameo@linux.intel.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.