From: Ted Ts'o <tytso@mit.edu>
To: Tao Ma <tm@tao.ma>
Cc: linux-ext4@vger.kernel.org, Lukas Czerner <lczerner@redhat.com>
Subject: Re: [PATCH 4/5] ext4: Speed up FITRIM by recording flags in ext4_group_info.
Date: Mon, 11 Jul 2011 00:07:27 -0400 [thread overview]
Message-ID: <20110711040727.GH28763@thunk.org> (raw)
In-Reply-To: <1309534076-2784-4-git-send-email-tm@tao.ma>
On Fri, Jul 01, 2011 at 11:27:55PM +0800, Tao Ma wrote:
> From: Tao Ma <boyu.mt@taobao.com>
>
> In ext4, when FITRIM is called every time, we iterate all the
> groups and do trim one by one. It is a bit time wasting if the
> group has been trimmed and there is no change since the last
> trim.
>
> So this patch adds a new flag in ext4_group_info->bb_state to
> indicate that the group has been trimmed, and it will be cleared
> if some blocks is freed(in release_blocks_on_commit). Another
> trim_minlen is added in ext4_sb_info to record the last minlen
> we use to trim the volume, so that if the caller provide a small
> one, we will go on the trim regardless of the bb_state.
Added to the ext4 tree, thanks.
- Ted
next prev parent reply other threads:[~2011-07-11 4:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-01 15:22 [PATCH 0/5 RESEND V2] ext4: trim bug fixes and improvements Tao Ma
2011-07-01 15:27 ` [PATCH 1/5] ext4: fix trim length underflow with small trim length Tao Ma
2011-07-01 15:27 ` [PATCH 2/5] ext4: speed up group trim with the right free block count Tao Ma
2011-07-11 4:06 ` Ted Ts'o
2011-07-01 15:27 ` [PATCH 3/5] ext4: Add new ext4 trim tracepoints Tao Ma
2011-07-11 4:07 ` Ted Ts'o
2011-07-01 15:27 ` [PATCH 4/5] ext4: Speed up FITRIM by recording flags in ext4_group_info Tao Ma
2011-07-11 4:07 ` Ted Ts'o [this message]
2011-07-01 15:27 ` [PATCH 5/5] ext4: Change the wrong param comment for ext4_trim_all_free Tao Ma
2011-07-11 4:07 ` Ted Ts'o
2011-07-11 4:06 ` [PATCH 1/5] ext4: fix trim length underflow with small trim length Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110711040727.GH28763@thunk.org \
--to=tytso@mit.edu \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tm@tao.ma \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.