Re: [PATCH] [media] tea5764: Fix module parameter permissions

[Jean Delvare <jdelvare@suse.de>]

Hi Andy,

On Friday 08 July 2011 12:34:38 pm Andy Walls wrote:
> Jean Delvare <jdelvare@suse.de> wrote:
> >The third parameter of module_param is supposed to represent sysfs
> >file permissions. A value of "1" leads to the following:
> >
> >$ ls -l /sys/module/radio_tea5764/parameters/
> >total 0
> >---------x 1 root root 4096 Jul  8 09:17 use_xtal
> >
> >I am changing it to "0" to align with the other module parameters in
> >this driver.
> >
> >Signed-off-by: Jean Delvare <jdelvare@suse.de>
> >Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
> >Cc: Fabio Belavenuto <belavenuto@gmail.com>
> >---
> > drivers/media/radio/radio-tea5764.c |    2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >---
> > linux-3.0-rc6.orig/drivers/media/radio/radio-tea5764.c	2011-05-20
> > 10:41:19.000000000 +0200
> >+++ linux-3.0-rc6/drivers/media/radio/radio-tea5764.c	2011-07-08
> >09:15:16.000000000 +0200
> >@@ -596,7 +596,7 @@ MODULE_AUTHOR(DRIVER_AUTHOR);
> > MODULE_DESCRIPTION(DRIVER_DESC);
> > MODULE_LICENSE("GPL");
> >
> >-module_param(use_xtal, int, 1);
> >+module_param(use_xtal, int, 0);
> > MODULE_PARM_DESC(use_xtal, "Chip have a xtal connected in board");
> > module_param(radio_nr, int, 0);
> > MODULE_PARM_DESC(radio_nr, "video4linux device number to use");
> 
> To whomever might know:
> 
> Was the intent of the "1" to set the default value of the parameter?

My guess is yes, and as a matter of fact 1 is indeed the default value 
of use_xtal. Only the author of the code (Fabio Belavenuto) could tell 
for sure, but he seems to be no longer involved so I wouldn't wait for 
him.

-- 
Jean Delvare
Suse L3