From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: crash in trace.c with large extra_data
Date: Mon, 11 Jul 2011 16:44:05 +0200
Message-ID: <20110711144404.GA17475@aepfle.de>
References: <20110711140256.GA23061@aepfle.de>
	<CAFLBxZbBf=BwEA0q5xWPhikPrNki8j081dmAL44+LMBEVAhh3g@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <CAFLBxZbBf=BwEA0q5xWPhikPrNki8j081dmAL44+LMBEVAhh3g@mail.gmail.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: George Dunlap <George.Dunlap@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

On Mon, Jul 11, George Dunlap wrote:

> The general idea is that callers of trace_var() *shouldn't* be calling
> with extra_words > TRACE_EXTRA_MAX.  It's an assert so that it breaks
> on debug builds, allowing programmers to fix the mistake (obviously
> mine in this case), but not on production builds.
> 
> I suppose it could be changed into a warning of some kind instead.

George,

a simple printk() would do it I think.

In this unfortunate case the system does not even reboot, need to find
someone to power cycle the box..

Olaf