From: Dave Jones <davej@redhat.com>
To: lfroen@galileo.co.il
Cc: Linux Kernel <linux-kernel@vger.kernel.org>, greg@kroah.com
Subject: staging/lirc_bt829: Return -ENODEV when no hardware is found.
Date: Mon, 11 Jul 2011 11:24:36 -0400 [thread overview]
Message-ID: <20110711152436.GA24104@redhat.com> (raw)
sys_init_module: 'lirc_bt829'->init suspiciously returned 1, it should follow 0/-E convention
sys_init_module: loading module anyway...
Pid: 8511, comm: modprobe Tainted: G WC 3.0.0-rc6+ #73
Call Trace:
[<ffffffff810b3da7>] sys_init_module+0x217/0x230
[<ffffffff815ed1d2>] system_call_fastpath+0x16/0x1b
Signed-off-by: Dave Jones <davej@redhat.com>
diff --git a/drivers/staging/lirc/lirc_bt829.c b/drivers/staging/lirc/lirc_bt829.c
index 3388102..c5a0d27 100644
--- a/drivers/staging/lirc/lirc_bt829.c
+++ b/drivers/staging/lirc/lirc_bt829.c
@@ -122,10 +122,10 @@ int init_module(void)
pdev = do_pci_probe();
if (pdev == NULL)
- return 1;
+ return -ENODEV;
if (!atir_init_start())
- return 1;
+ return -ENODEV;
strcpy(atir_driver.name, "ATIR");
atir_driver.minor = -1;
reply other threads:[~2011-07-11 15:24 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110711152436.GA24104@redhat.com \
--to=davej@redhat.com \
--cc=greg@kroah.com \
--cc=lfroen@galileo.co.il \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.