From: Ted Ts'o <tytso@mit.edu>
To: Robin Dong <hao.bigrat@gmail.com>
Cc: linux-ext4@vger.kernel.org, Robin Dong <sanbai@taobao.com>
Subject: Re: [PATCH 1/2] ext4: remove redundant goto tag "repeat"
Date: Mon, 11 Jul 2011 11:45:32 -0400 [thread overview]
Message-ID: <20110711154532.GL28763@thunk.org> (raw)
In-Reply-To: <1309421014-6148-1-git-send-email-sanbai@taobao.com>
On Thu, Jun 30, 2011 at 04:03:33PM +0800, Robin Dong wrote:
> If eh->eh_entries is smaller than eh->eh_max, the routine will
> go to the "repeat" and then go to "has_space" directlly ,
> since argument "depth" and "eh" are not even changed.
>
> Therefore, goto "has_space" directly and remove redundant "repeat" tag.
>
> Signed-off-by: Robin Dong <sanbai@taobao.com>
Thanks, added to the ext4 tree.
- Ted
prev parent reply other threads:[~2011-07-11 15:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-30 8:03 [PATCH 1/2] ext4: remove redundant goto tag "repeat" Robin Dong
2011-06-30 8:03 ` [PATCH 2/2] ext4: avoid finding next leaf if newext->ee_block smaller than fex->ee_block Robin Dong
2011-06-30 8:42 ` Yongqiang Yang
2011-07-11 19:52 ` Ted Ts'o
2011-07-12 1:33 ` Robin Dong
2011-07-11 17:07 ` Ted Ts'o
2011-06-30 11:56 ` [PATCH 1/2] ext4: remove redundant goto tag "repeat" Lukas Czerner
2011-07-11 15:45 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110711154532.GL28763@thunk.org \
--to=tytso@mit.edu \
--cc=hao.bigrat@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sanbai@taobao.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.