From: Ted Ts'o <tytso@mit.edu>
To: Lukas Czerner <lczerner@redhat.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: ext4_orphan_add() remove unnecessary comments
Date: Mon, 11 Jul 2011 18:47:34 -0400 [thread overview]
Message-ID: <20110711224734.GU28763@thunk.org> (raw)
In-Reply-To: <1309272617-30943-1-git-send-email-lczerner@redhat.com>
On Tue, Jun 28, 2011 at 04:50:17PM +0200, Lukas Czerner wrote:
> The comment from Al Viro about possible race in the ext4_orphan_add() is
> not justified. There is no race possible as we always have either i_mutex
> locked, or the inode can not be referenced from outside hence the
> J_ASSERS should not be hit from the reason described in comment.
>
> This commit replaces it with notion that we are holding i_mutex so it
> should not be possible for i_nlink to be changed while waiting for
> s_orphan_lock.
>
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
Applied, thanks.
- Ted
prev parent reply other threads:[~2011-07-11 22:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-28 14:50 [PATCH] ext4: ext4_orphan_add() remove unnecessary comments Lukas Czerner
2011-07-11 22:47 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110711224734.GU28763@thunk.org \
--to=tytso@mit.edu \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.