All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: alice wan <wanjia19870902@gmail.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: request of blkfront may disorder after migration without waiting in suspend phase of migration
Date: Tue, 12 Jul 2011 14:23:35 -0400	[thread overview]
Message-ID: <20110712182335.GA24828@dumpdata.com> (raw)
In-Reply-To: <CAKQ7UJnkTREkHw11_C46CTLzXwcgB_ADSGFONCMDKjPU=0nHKw@mail.gmail.com>

On Sun, Jul 10, 2011 at 12:36:06PM +0800, alice wan wrote:
> Hi konrad,
> 
> I found the mainline linux 3.0-rc6 xen-blkfront driver doesn't implement
> suspend func. In my opinion, the blkfront should wait till responses of all
> the pending requests come back, then domu can be suspended,

I think you mean blkback. It should be the job of blkback to account for
all I/Os and make sure they have completed before migrating?

I did have a patch for the 2.6.32 to deal with this but I never was able
to reproduce this. Are you able to reproduce this? Can you give me
step by step instructions on how to do it?

> otherwise,  after the migration, vm of target host will request from target
> host, meanwhile, the blkback of source host maybe do the pending requests
> until they's done.
> 
> if migrate the vm with high io pressure,  the requests of this vm may
> disorder.
> 
> And i saw the gpl windows pv driver, blkfront will change its state and wait
> for blkback closing, after blkback closing, the pending requests definitely
> are done.
> 
> More, i did some test with migration,  while vm was running dd task,  xm
> migrate -l .  before it suspend, gdb tapdisk2.  after migration, new vm
> started. then quit gdb, the pending request were written back to disk after
> new requests.
> 
> above mentioned is just my opinion, i need your advice and confirmation or
> deny
> 
> any help is appreciated.
> 
> 
> Regards
> 
> wanjia

> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel

  parent reply	other threads:[~2011-07-12 18:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-10  4:36 request of blkfront may disorder after migration without waiting in suspend phase of migration alice wan
2011-07-10  8:26 ` Daniel Stodden
2011-07-12 18:23 ` Konrad Rzeszutek Wilk [this message]
2011-07-13  9:09   ` Ian Campbell
2011-07-14  2:03     ` Daniel Stodden
2011-07-13 10:57   ` alice wan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110712182335.GA24828@dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=wanjia19870902@gmail.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.