From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Péter Ujfalusi" <peter.ujfalusi@ti.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"Cousson, Benoit" <b-cousson@ti.com>,
Tony Lindgren <tony@atomide.com>,
"Guiriec, Sebastien" <s-guiriec@ti.com>,
"Lopez Cruz, Misael" <misael.lopez@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"Girdwood, Liam" <lrg@ti.com>
Subject: Re: [PATCH 1/3] ASoC: omap-mcpdm: Replace legacy driver
Date: Wed, 13 Jul 2011 08:25:07 +0900 [thread overview]
Message-ID: <20110712232505.GA17710@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4479173.gaSts1MLKP@barack>
On Tue, Jul 12, 2011 at 10:35:53PM +0300, Péter Ujfalusi wrote:
> Just to avoid confusion (in my part): if I split this patch to one big +
> several small incremental patches, which eventually lead to the current
> situation is what you were asking for?
The rest of the patch looked fine from a code point of view so probably
just leave that as-is and improve the changelog - the delayed_work was
the only real issue I saw from a code point of view and the bit I was
suggesting to split out into a separate patch.
> With the patches I can document the reasoning behind the non standard
> workarounds. Probably if we see them spread out, we might be able to find
> better ways for them...
Yeah, and like I say if it were controlled by the machine driver it'd be
better.
next prev parent reply other threads:[~2011-07-12 23:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-07 12:27 [PATCH 0/3] OMAP4/ASoC: New McPDM driver Peter Ujfalusi
2011-07-07 12:27 ` [PATCH 1/3] ASoC: omap-mcpdm: Replace legacy driver Peter Ujfalusi
2011-07-07 15:57 ` Mark Brown
2011-07-07 16:32 ` Liam Girdwood
2011-07-07 16:53 ` Mark Brown
2011-07-07 17:19 ` Péter Ujfalusi
2011-07-07 19:55 ` Liam Girdwood
2011-07-08 14:28 ` Mark Brown
2011-07-08 15:02 ` Péter Ujfalusi
2011-07-09 1:08 ` Mark Brown
2011-07-12 19:35 ` Péter Ujfalusi
2011-07-12 23:25 ` Mark Brown [this message]
2011-07-07 12:27 ` [PATCH 2/3] OMAP: McPDM: Convert McPDM device to omap_device Peter Ujfalusi
2011-07-07 15:58 ` Mark Brown
2011-07-07 12:27 ` [PATCH 3/3] OMAP4: hwmod: enable mcpdm hwmod device Peter Ujfalusi
2011-07-07 15:58 ` Mark Brown
2011-07-26 13:46 ` Cousson, Benoit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110712232505.GA17710@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=b-cousson@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@ti.com \
--cc=misael.lopez@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=s-guiriec@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.