All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Mundt <lethal@linux-sh.org>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] carminefb: Fix module parameters permissions
Date: Wed, 13 Jul 2011 08:19:19 +0000	[thread overview]
Message-ID: <20110713081919.GG13701@linux-sh.org> (raw)
In-Reply-To: <201107081104.38854.jdelvare@suse.de>

On Fri, Jul 08, 2011 at 11:04:38AM +0200, Jean Delvare wrote:
> The third parameter of module_param is supposed to be an octal value.
> The missing leading "0" causes the following:
> 
> $ ls -l /sys/module/carminefb/parameters/
> total 0
> -rw-rwxr-- 1 root root 4096 Jul  8 08:55 fb_displays
> -rw-rwxr-- 1 root root 4096 Jul  8 08:55 fb_mode
> -rw-rwxr-- 1 root root 4096 Jul  8 08:55 fb_mode_str
> 
> After fixing the perm parameter, we get the expected:
> 
> $ ls -l /sys/module/carminefb/parameters/
> total 0
> -r--r--r-- 1 root root 4096 Jul  8 08:56 fb_displays
> -r--r--r-- 1 root root 4096 Jul  8 08:56 fb_mode
> -r--r--r-- 1 root root 4096 Jul  8 08:56 fb_mode_str
> 
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Paul Mundt <lethal@linux-sh.org>
> Cc: Sebastian Siewior <bigeasy@linutronix.de>
> Cc: stable@kernel.org
> ---
>  drivers/video/carminefb.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
Applied, thanks.

      reply	other threads:[~2011-07-13  8:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-08  9:04 [PATCH] carminefb: Fix module parameters permissions Jean Delvare
2011-07-13  8:19 ` Paul Mundt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110713081919.GG13701@linux-sh.org \
    --to=lethal@linux-sh.org \
    --cc=linux-fbdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.