Re: [PATCH v2] xen-netfront: delay gARP until backend switches to Connected

[Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>]

On Wed, Jul 13, 2011 at 01:44:47PM +0200, Laszlo Ersek wrote:
> In addition to backporting 43223efd9bfd to the RHEL-5 host side, we needed the
> following in the RHEL-6 guest, in order to fix the network outage after live
> migration. I also tested a Fedora-15 guest (without the patch), and the

Laszlo,

This description is .. well, pointless for upstream patches. Just succinctly
describe the problem, how to reproduce it, and what this patch does.

And do mention more about 43223efd9bfd, like "this is the front
counterpart of patch xen: netback: wait for hotplug scripts to complete before
signalling connected to frontend (43223efd9bfd)"

> backport to the host side alone was not sufficient there either. Therefore I
> think it could be useful to apply this guest-side patch to upstream as well.
> 
> Reference: https://bugzilla.redhat.com/show_bug.cgi?id=713585
> 
> v1->v2: "port" to Linus's tree; add RHBZ ref.
> 
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>  drivers/net/xen-netfront.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
> index d29365a..f033656 100644
> --- a/drivers/net/xen-netfront.c
> +++ b/drivers/net/xen-netfront.c
> @@ -1646,7 +1646,6 @@ static void netback_changed(struct xenbus_device *dev,
>  	case XenbusStateInitialised:
>  	case XenbusStateReconfiguring:
>  	case XenbusStateReconfigured:
> -	case XenbusStateConnected:
>  	case XenbusStateUnknown:
>  	case XenbusStateClosed:
>  		break;
> @@ -1657,6 +1656,9 @@ static void netback_changed(struct xenbus_device *dev,
>  		if (xennet_connect(netdev) != 0)
>  			break;
>  		xenbus_switch_state(dev, XenbusStateConnected);
> +		break;
> +
> +	case XenbusStateConnected:
>  		netif_notify_peers(netdev);
>  		break;
>  
> -- 
> 1.7.4.4
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel