Re: [PATCH 11/24] ath6kl: add htc.c

[Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>]

On Wed, Jul 13, 2011 at 05:33:04AM -0700, Joe Perches wrote:
> On Wed, 2011-07-13 at 10:46 +0300, Kalle Valo wrote:
> > On 07/13/2011 07:30 AM, Joe Perches wrote:
> > > On Wed, 2011-07-13 at 04:34 +0300, Kalle Valo wrote: 
> > >> Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
> > >> diff --git a/drivers/net/wireless/ath/ath6kl/htc.c b/drivers/net/wireless/ath/ath6kl/htc.c
> > > [] 
> > >> +static void htc_tx_comp_update(struct htc_target *target,
> > >> +			       struct htc_endpoint *endpoint,
> > >> +			       struct htc_packet *packet)
> > >> +{
> > > [] 
> > >> 	ath6kl_dbg(ATH6KL_DBG_HTC_SEND, "ctxt:0x%lx dist:0x%lx\n",
> > >> +		(unsigned long) target->cred_dist_cntxt,
> > >> +		(unsigned long *) &target->cred_dist_list);
> > > compiler warning?
> > I haven't seen any. But all these unsigned long casts will be removed
> > anyway.
> 
> You need to update debug.h [08/24]
> 
> > diff --git a/drivers/net/wireless/ath/ath6kl/debug.h b/drivers/net/wireless/ath/ath6kl/debug.h
> []
> > +extern int ath6kl_printk(const char *level, const char *fmt, ...);
> 
> You're not seeing compiler warnings for mismatched
> arguments because this should to be:
> 
> extern __attribute__((format (printf, 2, 3)))
> int ath6kl_printk(const char *level, const char *fmt, ...);

Right, format attribute exposes quite a few mismatch in format
string, we'll address them in next version. Thanks for pointing this out

Vasanth