All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Matt Fleming <matt.fleming@linux.intel.com>,
	Dave Hansen <dave@linux.vnet.ibm.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH] acct_arg_size: ptl is no longer needed for add_mm_counter()
Date: Wed, 13 Jul 2011 21:39:35 +0200	[thread overview]
Message-ID: <20110713193935.GA18026@redhat.com> (raw)

acct_arg_size() takes ->page_table_lock around add_mm_counter()
if !SPLIT_RSS_COUNTING. This is no needed after 172703b0
"mm: delete non-atomic mm counter implementation".

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---

 fs/exec.c |    7 -------
 1 file changed, 7 deletions(-)

--- ptrace/fs/exec.c~acct_arg_size-no-ptl	2011-07-10 16:20:01.000000000 +0200
+++ ptrace/fs/exec.c	2011-07-13 21:36:29.000000000 +0200
@@ -181,14 +181,7 @@ static void acct_arg_size(struct linux_b
 		return;
 
 	bprm->vma_pages = pages;
-
-#ifdef SPLIT_RSS_COUNTING
 	add_mm_counter(mm, MM_ANONPAGES, diff);
-#else
-	spin_lock(&mm->page_table_lock);
-	add_mm_counter(mm, MM_ANONPAGES, diff);
-	spin_unlock(&mm->page_table_lock);
-#endif
 }
 
 static struct page *get_arg_page(struct linux_binprm *bprm, unsigned long pos,


             reply	other threads:[~2011-07-13 19:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-13 19:39 Oleg Nesterov [this message]
2011-07-14 13:44 ` [PATCH] acct_arg_size: ptl is no longer needed for add_mm_counter() Matt Fleming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110713193935.GA18026@redhat.com \
    --to=oleg@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=dave@linux.vnet.ibm.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt.fleming@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.