From: Guenter Roeck <guenter.roeck@ericsson.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] RFC: Moving pmbus drivers into hwmon subdirectory
Date: Thu, 14 Jul 2011 13:46:18 +0000 [thread overview]
Message-ID: <20110714134618.GA6273@ericsson.com> (raw)
In-Reply-To: <20110712021230.GA22766@ericsson.com>
On Thu, Jul 14, 2011 at 07:52:24AM -0400, Jean Delvare wrote:
> On Tue, 12 Jul 2011 08:38:49 +0200, Jean Delvare wrote:
> > On Mon, 11 Jul 2011 19:12:30 -0700, Guenter Roeck wrote:
> > > Hi all,
> > >
> > > since the number of PMBus slave/client drivers keeps getting larger,
> > > I have been wondering if I should move them into a separate subdirectory,
> > > most likely drivers/hwmon/pmbus/.
> > >
> > > Any thoughts/comments about that ?
> >
> > Seems to be a good idea, yes.
>
> Thinking some more about this... Does PMBus fit entirely in hwmon, or
> does it cover additional functions? If it does cover additional
> functions, then maybe drivers/pmbus would be a better place.
>
Hi Jean,
The functionality implemented today is pure hwmon functionality and thus
belongs entirely into hwmon.
It may at some point be of interest to add regulator functionality.
If so, the way to do it would be to move generic (ie chip read/write code)
functionality to mfd and implement regulator and hwmon frontends.
I would be very hesitant to do that, though. First, I have not seen an actual
use case for it, and second it is extremely dangerous to change voltages,
and very easy to literally blow up a chip or even an entire board
if a chip is programmed with values it does not like (I have blown up
several of my test boards ;).
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
prev parent reply other threads:[~2011-07-14 13:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-12 2:12 [lm-sensors] RFC: Moving pmbus drivers into hwmon subdirectory Guenter Roeck
2011-07-12 6:38 ` Jean Delvare
2011-07-14 11:52 ` Jean Delvare
2011-07-14 13:46 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110714134618.GA6273@ericsson.com \
--to=guenter.roeck@ericsson.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.