From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org, Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH] regulator: Fix memory leak in set_machine_constraints() error paths
Date: Fri, 15 Jul 2011 08:48:07 +0900 [thread overview]
Message-ID: <20110714234805.GA32716@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1310650159.6854.1.camel@phoenix>
On Thu, Jul 14, 2011 at 09:29:19PM +0800, Axel Lin wrote:
> static int set_machine_constraints(struct regulator_dev *rdev,
> const struct regulation_constraints *constraints)
> {
> - int ret = 0;
> + int ret;
> struct regulator_ops *ops = rdev->desc->ops;
>
This doesn't look like a leak fix? There's nothing that checks for
other errors here (like null pointers)?
next prev parent reply other threads:[~2011-07-14 23:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-14 13:29 [PATCH] regulator: Fix memory leak in set_machine_constraints() error paths Axel Lin
2011-07-14 23:48 ` Mark Brown [this message]
2011-07-15 0:44 ` Axel Lin
2011-07-15 2:43 ` Mark Brown
2011-07-15 2:48 ` Axel Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110714234805.GA32716@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=axel.lin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.