All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olaf Hering <olaf@aepfle.de>
To: "Roger Pau Monné" <roger.pau@entel.upc.edu>
Cc: Ian Campbell <Ian.Campbell@eu.citrix.com>,
	Christoph Egger <Christoph.Egger@amd.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] Fix xencommons for NetBSD
Date: Fri, 15 Jul 2011 13:44:08 +0200	[thread overview]
Message-ID: <20110715114407.GA17857@aepfle.de> (raw)
In-Reply-To: <CAPLaKK5Q4T39NFUT5g91L9p7Sj5oKg8zKPVs+QaqwBKqBPQ7dg@mail.gmail.com>

On Fri, Jul 15, Roger Pau Monné wrote:

> Another one, used -n instead of -z when testing the presence of
> XENSTORED_ROOTDIR. Sorry for this mess, I'm not really used to make
> shell init scripts.

+       xenstored_pid=$(check_pidfile ${XENSTORED_PIDFILE} ${SBINDIR}/xenstored)
+       if test -z $xenstored_pid; then

Doesnt this expand to 'if test -z ; then' if check_pidfile returns
nothing, causing a shell syntax error?
Better do 'if test -z "$variable" ; then'.

Olaf

  parent reply	other threads:[~2011-07-15 11:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-15  7:38 [PATCH] Fix xencommons for NetBSD Roger Pau Monné
2011-07-15  8:01 ` Ian Campbell
2011-07-15  8:59   ` Christoph Egger
2011-07-15  9:13     ` Ian Campbell
2011-07-15  9:18       ` Roger Pau Monné
2011-07-15  9:40         ` Ian Campbell
2011-07-15  9:55           ` Roger Pau Monné
2011-07-15 10:08             ` Ian Campbell
2011-07-15 11:27               ` Roger Pau Monné
2011-07-15 11:37                 ` Christoph Egger
2011-07-15 11:44                 ` Olaf Hering [this message]
2011-07-15 11:56                   ` Ian Campbell
2011-07-15 12:06                     ` Roger Pau Monné
2011-07-15 17:22                       ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110715114407.GA17857@aepfle.de \
    --to=olaf@aepfle.de \
    --cc=Christoph.Egger@amd.com \
    --cc=Ian.Campbell@eu.citrix.com \
    --cc=roger.pau@entel.upc.edu \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.