From: David Gibson <david@gibson.dropbear.id.au>
To: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Cc: jdl@jdl.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2] dtc: Remove unused variable in flat_read_mem_reserve
Date: Fri, 15 Jul 2011 23:57:55 +1000 [thread overview]
Message-ID: <20110715135755.GD4368@yookeroo.fritz.box> (raw)
In-Reply-To: <20110628134711.GF10237@zod.rchland.ibm.com>
On Tue, Jun 28, 2011 at 09:47:11AM -0400, Josh Boyer wrote:
> The *p variable is declared and used to save inb->ptr, however p is
> later never used. This has been the case since commit 6c0f3676 and can
> lead to build failures with -Werror=unused-but-set-variable:
>
> flattree.c: In function 'flat_read_mem_reserve':
> flattree.c:700:14: error: variable 'p' set but not used [-Werror=unused-but-set-variable]
> cc1: all warnings being treated as errors
> make: *** [flattree.o] Error 1
>
> Remove the variable.
>
> Signed-off-by: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
Jon, please apply.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2011-07-15 13:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-28 13:47 [PATCH v2] dtc: Remove unused variable in flat_read_mem_reserve Josh Boyer
2011-07-15 13:57 ` David Gibson [this message]
2011-07-17 12:36 ` Jon Loeliger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110715135755.GD4368@yookeroo.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=jdl@jdl.com \
--cc=jwboyer@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.