From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754008Ab1GOXc1 (ORCPT ); Fri, 15 Jul 2011 19:32:27 -0400 Received: from e9.ny.us.ibm.com ([32.97.182.139]:33037 "EHLO e9.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751278Ab1GOXc0 (ORCPT ); Fri, 15 Jul 2011 19:32:26 -0400 Date: Fri, 15 Jul 2011 16:32:03 -0700 From: "Paul E. McKenney" To: Frederic Weisbecker Cc: LKML , Thomas Gleixner , "H. Peter Anvin" , David Miller , Chris Metcalf , Guan Xuetao , Hans-Christian Egtvedt , Mike Frysinger , Ralf Baechle , Peter Zijlstra , Russell King , Paul Mackerras , Heiko Carstens , Paul Mundt Subject: Re: [PATCH 0/3] rcu: Fix some rcu uses in extended quiescent state Message-ID: <20110715233203.GM2327@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <1310416472-2554-1-git-send-email-fweisbec@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1310416472-2554-1-git-send-email-fweisbec@gmail.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 11, 2011 at 10:34:29PM +0200, Frederic Weisbecker wrote: > Hi, > > First patch lays the ground to fix rcu uses in dyntick idle mode > by splitting rcu extended qs state logic from tick nohz one. > > The rest fixes the misuses that RCU has detected for me in x86. These look good to me -- I have queued them and will try testing them out. > I'll try to fix those Paul has detected in PowerPc. Looking forward to that one as well. ;-) It would be really cool if this approach could serve as RCU's idle-CPU detection regardless of whether or not CONFIG_NO_HZ was set. For one thing, this would simplify the RCU code that treats idle tasks as extended quiescent states. Except during boot time. :-/ Thanx, Paul > Frederic Weisbecker (3): > nohz: Split extended quiescent state handling from nohz switch > x86: Enter rcu extended qs after idle notifier call > x86: Call idle notifier after irq_enter() > > arch/arm/kernel/process.c | 4 +- > arch/avr32/kernel/process.c | 4 +- > arch/blackfin/kernel/process.c | 4 +- > arch/microblaze/kernel/process.c | 4 +- > arch/mips/kernel/process.c | 4 +- > arch/powerpc/kernel/idle.c | 4 +- > arch/powerpc/platforms/iseries/setup.c | 8 +++--- > arch/s390/kernel/process.c | 4 +- > arch/sh/kernel/idle.c | 2 +- > arch/sparc/kernel/process_64.c | 4 +- > arch/tile/kernel/process.c | 4 +- > arch/um/kernel/process.c | 4 +- > arch/unicore32/kernel/process.c | 4 +- > arch/x86/kernel/apic/apic.c | 6 ++-- > arch/x86/kernel/apic/io_apic.c | 2 +- > arch/x86/kernel/cpu/mcheck/mce.c | 2 +- > arch/x86/kernel/cpu/mcheck/therm_throt.c | 2 +- > arch/x86/kernel/cpu/mcheck/threshold.c | 2 +- > arch/x86/kernel/irq.c | 6 ++-- > arch/x86/kernel/process_32.c | 4 +- > arch/x86/kernel/process_64.c | 5 ++++ > include/linux/tick.h | 10 +++++-- > kernel/time/tick-sched.c | 36 ++++++++++++++++++++++++++--- > 23 files changed, 83 insertions(+), 46 deletions(-) > > -- > 1.7.5.4 >