From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: Benny Halevy <bhalevy@panasas.com>, <osd-dev@open-osd.org>,
Jonathan Cameron <jic23@cam.ac.uk>,
LKML <linux-kernel@vger.kernel.org>, Tejun Heo <tj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: RFC: Boiler plate functions for ida / idr allocation?
Date: Fri, 15 Jul 2011 23:35:22 +0200 [thread overview]
Message-ID: <20110715233522.66fd988f@stein> (raw)
In-Reply-To: <4E208302.9020908@panasas.com>
On Jul 15 Boaz Harrosh wrote:
> On 07/13/2011 05:41 AM, Stefan Richter wrote:
> > osd_uld.c::osd_minor_ida is accessed unsafely.
> > Device probe() and remove() methods are not globally serialized.
>
> Sorry for the delay. Vacation
>
> Thanks Stefan I'll look into it. I remember I thought about
> it and tested it at the time, but I might be wrong. I'll look
> into it.
Could actually be that there was or even still is some degree of
serialization by the SCSI core in typical usage. But I think the
general case is nowadays fully concurrent. E.g.
echo $name > /sys/bus/scsi/drivers/osd*/{,un}bind
if issued in parallel for different device names. Though it is probably
borderline impossible to actually hit a concurrent osd_minor_ida access on
purpose.
--
Stefan Richter
-=====-==-== -=== -====
http://arcgraph.de/sr/
next prev parent reply other threads:[~2011-07-15 21:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-13 9:44 RFC: Boiler plate functions for ida / idr allocation? Jonathan Cameron
2011-07-13 12:41 ` Stefan Richter
2011-07-15 18:12 ` Boaz Harrosh
2011-07-15 21:35 ` Stefan Richter [this message]
2011-07-13 13:14 ` Stefan Richter
2011-07-13 13:17 ` Jonathan Cameron
2011-07-13 13:31 ` Tejun Heo
2011-07-13 13:48 ` Jonathan Cameron
2011-07-21 6:50 ` Rusty Russell
2011-07-21 7:37 ` Rusty Russell
2011-07-21 8:19 ` Tejun Heo
2011-07-21 8:29 ` Jonathan Cameron
2011-07-21 8:35 ` Tejun Heo
2011-07-22 11:13 ` Rusty Russell
2011-07-22 16:43 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110715233522.66fd988f@stein \
--to=stefanr@s5r6.in-berlin.de \
--cc=akpm@linux-foundation.org \
--cc=bhalevy@panasas.com \
--cc=bharrosh@panasas.com \
--cc=jic23@cam.ac.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=osd-dev@open-osd.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.