All of lore.kernel.org
 help / color / mirror / Atom feed
From: "jiangtao.jit" <jiangtao.jit@gmail.com>
To: "linux-kernel" <linux-kernel@vger.kernel.org>
Subject: problem with function vlan_get_protocol()
Date: Sun, 17 Jul 2011 11:51:50 +0800	[thread overview]
Message-ID: <201107171151478596113@gmail.com> (raw)

Hi,all

in file   inclue/linux/if_vlan.h

there is a statement in function vlan_get_protocol()

	if (likely(protop))
		protocol = *protop;

do we need an else branch on pointer protop failed through the else is unlikely 

	if (likely(protop))
		protocol = *protop;
    else
		protocol = proto;

thanks

----------------------
2011-07-17 
jiangtao.jit 


             reply	other threads:[~2011-07-17  3:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-17  3:51 jiangtao.jit [this message]
2011-07-17  4:17 ` problem with function vlan_get_protocol() David Miller
2011-07-17  4:49 ` jiangtao.jit
  -- strict thread matches above, loose matches on Subject: below --
2011-07-17  4:53 jiangtao.jit
2011-07-17  7:34 ` Francois Romieu
2011-07-17  8:15 ` jiangtao.jit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201107171151478596113@gmail.com \
    --to=jiangtao.jit@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.