From: Frederic Weisbecker <fweisbec@gmail.com>
To: David Ahern <dsahern@gmail.com>,
peterz@infradead.org,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Ingo Molnar <mingo@elte.hu>
Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
paulus@samba.org
Subject: Re: [PATCH v2] perf tools: fix endian conversion reading event attr from file header
Date: Sun, 17 Jul 2011 20:12:04 +0200 [thread overview]
Message-ID: <20110717181202.GC29355@somewhere> (raw)
In-Reply-To: <1310754849-12474-1-git-send-email-dsahern@gmail.com>
On Fri, Jul 15, 2011 at 12:34:09PM -0600, David Ahern wrote:
> The perf_event_attr struct has 2 __u32's at the top and need to
> be swapped individually. With this change I was able to analyze
> a perf.data collected in a 32-bit PPC VM on an x86 system. I
> tested both 32-bit and 64-bit binaries for the Intel analysis
> side; both read the PPC perf.data file correctly.
>
> v1 -> v2:
> - changed the existing perf_event__attr_swap to swap only elements
> of perf_event_attr and exported it for use in swapping the
> attributes in the file header
> - updated swap_ops used for processing events
>
> Signed-off-by: David Ahern <dsahern@gmail.com>
Thanks!
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
next prev parent reply other threads:[~2011-07-17 18:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-15 18:34 [PATCH v2] perf tools: fix endian conversion reading event attr from file header David Ahern
2011-07-17 18:12 ` Frederic Weisbecker [this message]
2011-07-21 10:10 ` [tip:perf/core] perf tools: Fix " tip-bot for David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110717181202.GC29355@somewhere \
--to=fweisbec@gmail.com \
--cc=acme@ghostprotocols.net \
--cc=dsahern@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.