All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ted Ts'o <tytso@mit.edu>
To: Robin Dong <hao.bigrat@gmail.com>
Cc: linux-ext4@vger.kernel.org, Robin Dong <sanbai@taobao.com>
Subject: Re: [PATCH v3] ext4: avoid wasted extent cache lookup if !PUNCH_OUT_EXT
Date: Sun, 17 Jul 2011 23:28:58 -0400	[thread overview]
Message-ID: <20110718032858.GD14869@thunk.org> (raw)
In-Reply-To: <1309309071-2244-1-git-send-email-sanbai@taobao.com>

On Wed, Jun 29, 2011 at 08:57:51AM +0800, Robin Dong wrote:
> This patch avoids an extraneous lookup of the extent cache
> in ext4_ext_map_blocks() when the flag
> EXT4_GET_BLOCKS_PUNCH_OUT_EXT is absent.
> 
> The existing logic was performing the lookup but not making
> use of the result. The patch simply reverses the order of evaluation
> in the condition.
> 
> Since ext4_ext_in_cache() does not initialize newex on misses, bypassing
> its invocation does not introduce any new issue in this regard.
> 
> Signed-off-by: Robin Dong <sanbai@taobao.com>
> Reviewed-by: Lukas Czerner <lczerner@redhat.com>
> Reviewed-by: Eric Gouriou <egouriou@google.com>

Thanks added to the ext4 tree.

						- Ted

      parent reply	other threads:[~2011-07-18  3:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-29  0:57 [PATCH v3] ext4: avoid wasted extent cache lookup if !PUNCH_OUT_EXT Robin Dong
2011-06-29  1:30 ` Steven Liu
2011-07-18  3:28 ` Ted Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110718032858.GD14869@thunk.org \
    --to=tytso@mit.edu \
    --cc=hao.bigrat@gmail.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=sanbai@taobao.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.