All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: agk@redhat.com, dm-devel@redhat.com
Cc: Milan Broz <mbroz@redhat.com>
Subject: Re: [PATCH v2] dm table: simplify discard support processing
Date: Mon, 18 Jul 2011 11:10:56 -0400	[thread overview]
Message-ID: <20110718151055.GA7744@redhat.com> (raw)
In-Reply-To: <20110714175647.GA31051@redhat.com>

Updated patch header to also point out the fix:

Remove 'discards_supported' from the dm_table structure.  The same
information can be easily discovered from the table's target(s) in
dm_table_supports_discards().

This change fixes an issue with per-target 'discards_supported' being
ineffective, at insuring the final DM device advertises discard support,
due to a different target not having 'num_discard_requests' > 0 -- this
resulted in the overall table's 'discards_supported' being set to 0.

Also DMWARN if a target sets 'discards_supported' override but forgets
to set 'num_discard_requests'.

  reply	other threads:[~2011-07-18 15:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-14 14:30 [PATCH] dm table: simplify discard support processing Mike Snitzer
2011-07-14 15:43 ` Milan Broz
2011-07-14 16:11   ` Mike Snitzer
2011-07-14 17:56 ` [PATCH v2] " Mike Snitzer
2011-07-18 15:10   ` Mike Snitzer [this message]
2011-07-21  2:53     ` [PATCH v3] dm table: fix and " Mike Snitzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110718151055.GA7744@redhat.com \
    --to=snitzer@redhat.com \
    --cc=agk@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=mbroz@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.