From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 04/10] i965: setup system routine Date: Tue, 19 Jul 2011 04:48:50 +0000 Message-ID: <20110719044850.GA29993@cloud01> References: <1310945148-6777-1-git-send-email-ben@bwidawsk.net> <1310945148-6777-5-git-send-email-ben@bwidawsk.net> <874o2jjvtm.fsf@eliezer.anholt.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1633544873==" Return-path: In-Reply-To: <874o2jjvtm.fsf@eliezer.anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Eric Anholt Cc: mesa-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1633544873== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="IS0zKkzwUGydFO0o" Content-Disposition: inline --IS0zKkzwUGydFO0o Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 18, 2011 at 11:19:17AM -0700, Eric Anholt wrote: > On Sun, 17 Jul 2011 16:25:42 -0700, Ben Widawsky wrote: > > Upload the system routine as part of the invariant state if debugging. > >=20 > > Remove SIP setting if not debugging to make it more friendly for others > > that may be debugging shaders or media kernels. > >=20 > > v2: removed comment per Chris >=20 > This patch doesn't really make sense to me. Nothing good will come of > my driver's buffer execution landing inside someone else's debug kernel, > right? So why should my driver's batchbuffer be leaving their SIP in > place? Yeah you're right. Furthermore, the default value should be 0, which should= be all good all around. Initially I was trying to do something fancier here, detecting when the SIP has been changed external to mesa, but I gave up on that. I will remove the condition and always set sip. Ben --IS0zKkzwUGydFO0o Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQEcBAEBAgAGBQJOJQyxAAoJEL9nTIiJEj0pPfMH/iZpE84VmKSnCG9+lZB9kIzv GC75OE/CIUaJ3lSOaqBtG4ToG91pf2D6YT1I417W8rONK+vWsagwqQA00uoOtv7/ Bhjip9/gaUO2mVXmI1rtvLOM9NimtbmF38R8koNAZextiEpKTphldy9TVY0hTfn+ HI0tbcsY9cE1Dt0QvaNHHkazXsgKnWyPy16/+unsODHU05JhUagyg0cd2Z8Vao71 NstgfBzuHaNvRuyN0Gb1uyXrbKaopFJJJmYN8x3Ie8zccut8vTNuNFUjbDAh7vDI o8KgJm4u9MVEZETLYl43uTeqEQinWKRmIcmDpzmIKhLdlM0hJw1LWLGh+DOoUuw= =qLJH -----END PGP SIGNATURE----- --IS0zKkzwUGydFO0o-- --===============1633544873== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1633544873==--