From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: Zeng Zhaoming <zhaoming.zeng@freescale.com>,
alsa-devel@alsa-project.org, Dong Aisheng <b29396@freescale.com>,
Zeng Zhaoming <b32542@freescale.com>
Subject: Re: [PATCH 0/3] make the sgtl5000-codec work
Date: Tue, 19 Jul 2011 16:13:37 +0100 [thread overview]
Message-ID: <20110719151337.GG9652@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20110719090404.GD1951@pengutronix.de>
On Tue, Jul 19, 2011 at 11:04:04AM +0200, Wolfram Sang wrote:
> > pls check http://comments.gmane.org/gmane.linux.alsa.devel/83781
> >
> > I think Mark is right, sgtl5000 already declared its register_step is 2, soc_cache.c
> > should generate a dense cache layout instead of padding it by driver.
> Thanks for the pointer. I can follow Mark's reasoning. In fact, I was
> wondering why ASoC does not consider the step, but I assumed it was
> intentional. With my holidays coming along, nothing I am going to
> tackle in the next time, though ;)
The only reason steps are ever used is for AC'97 devices which don't use
the generic cache code as they're pretty much obsolete so the framework
support is mostly just carried around as legacy. The step size is used
in the cache display code which does use it. If someone was interested
enough to convert AC'97 over that'd be nice.
next prev parent reply other threads:[~2011-07-19 15:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-18 15:53 [PATCH 0/3] make the sgtl5000-codec work Wolfram Sang
2011-07-18 15:53 ` [PATCH 1/3] ASoC: sgtl5000: refactor registering internal ldo Wolfram Sang
2011-07-19 15:20 ` Mark Brown
2011-07-18 15:53 ` [PATCH 2/3] ASoC: sgtl5000: guide user when regulator support is needed Wolfram Sang
2011-07-18 15:53 ` [PATCH 3/3] ASoC: sgtl5000: fix cache handling Wolfram Sang
2011-07-18 19:16 ` [PATCH 0/3] make the sgtl5000-codec work Zeng Zhaoming
2011-07-19 9:04 ` Wolfram Sang
2011-07-19 10:09 ` Liam Girdwood
2011-07-19 15:13 ` Mark Brown [this message]
2011-07-19 16:46 ` Wolfram Sang
2011-07-19 16:59 ` Mark Brown
2011-07-19 2:56 ` Dong Aisheng
2011-07-19 5:09 ` Shawn Guo
2011-07-19 5:32 ` Dong Aisheng
2011-07-19 15:09 ` Mark Brown
2011-07-19 16:52 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110719151337.GG9652@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=b29396@freescale.com \
--cc=b32542@freescale.com \
--cc=w.sang@pengutronix.de \
--cc=zhaoming.zeng@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.