All of lore.kernel.org
 help / color / mirror / Atom feed
From: Todd Poynor <toddpoynor@google.com>
To: Tejun Heo <tj@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: Crash in schedule path after worker thread dies
Date: Tue, 19 Jul 2011 17:07:38 -0700	[thread overview]
Message-ID: <20110720000738.GA18774@google.com> (raw)

After a worker thread died due to a bug in a work function, a NULL
dereference was seen when schedule calls wq_worker_sleeping calls
kthread_data:

          return to_kthread(task)->data;

mm_release has apparently already set the task's vfork_done = NULL,
causing to_kthread to return a bad address (on 3.0-rc7 on ARM).

I haven't tried a fix because I'm not sure if avoiding this case is
enough to properly recover from death of a worker thread, or if this
has already been discussed and rejected in the past.  I searched
around a little and found some mentions of problems in worker
functions that were probably followed by the kthread_data crash,
but didn't turn up any specific discussion of this crash.  So I
thought I'd start by mentioning this here, and can help fix or test if
needed.


Todd

             reply	other threads:[~2011-07-20  0:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-20  0:07 Todd Poynor [this message]
2011-07-20 17:07 ` Crash in schedule path after worker thread dies Tejun Heo
2011-07-20 18:06   ` Todd Poynor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110720000738.GA18774@google.com \
    --to=toddpoynor@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.