From: "John W. Linville" <linville@tuxdriver.com>
To: Pavel Roskin <proski@gnu.org>
Cc: sedat.dilek@gmail.com, Sedat Dilek <sedat.dilek@googlemail.com>,
Nick Kossifidis <mickflemm@gmail.com>,
ath5k-devel@venema.h4ckr.net, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] ath5k: merge ath5k_hw and ath5k_softc
Date: Wed, 20 Jul 2011 16:00:04 -0400 [thread overview]
Message-ID: <20110720200004.GB18231@tuxdriver.com> (raw)
In-Reply-To: <4E2733BC.3070309@gnu.org>
On Wed, Jul 20, 2011 at 03:59:56PM -0400, Pavel Roskin wrote:
> On 07/20/2011 06:19 AM, Sedat Dilek wrote:
>
> >I have tested this patch on top of linux-next (next-20110720) and it fails:
>
> The patch is for wireless-testing.
>
> >In file included from
> >/mnt/sdb3/linux-kernel/linux-3.0-rc7/debian/build/source_i386_none/drivers/net/wireless/ath/ath5k/caps.c:24:0:
> >/mnt/sdb3/linux-kernel/linux-3.0-rc7/debian/build/source_i386_none/drivers/net/wireless/ath/ath5k/ath5k.h:1072:24:
> >error: field 'toggleq' has incomplete type
>
> It looks like ath5.h needs to include linux/interrupt.h, which is
> currently included by base.h.
>
> linux-next is stricter about the includes than wireless-testing.
> Let's not break linux-next, as someone else will need to fix it.
>
> I'll send another version of the patch, tested both on
> wireless-testing and linux-next.
I already merged a version that incorporated Sedat's change on top
of your. If that isn't what you want, please post your change as a
patch on top.
Thanks,
JOhn
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2011-07-20 20:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-15 0:21 [PATCH v2] ath5k: merge ath5k_hw and ath5k_softc Pavel Roskin
2011-07-20 1:39 ` Nick Kossifidis
2011-07-20 10:19 ` Sedat Dilek
2011-07-20 11:54 ` Sedat Dilek
2011-07-20 19:59 ` Pavel Roskin
2011-07-20 20:00 ` John W. Linville [this message]
2011-07-20 21:59 ` Pavel Roskin
2011-07-23 19:18 ` Sedat Dilek
2011-07-23 20:57 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110720200004.GB18231@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=ath5k-devel@venema.h4ckr.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mickflemm@gmail.com \
--cc=proski@gnu.org \
--cc=sedat.dilek@gmail.com \
--cc=sedat.dilek@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.