From: Oleg Nesterov <oleg@redhat.com>
To: Vasiliy Kulikov <segoon@openwall.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Balbir Singh <bsingharora@gmail.com>,
Jerome Marchand <jmarchan@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] taskstats: add_del_listener() should ignore !valid listener's
Date: Thu, 21 Jul 2011 16:29:20 +0200 [thread overview]
Message-ID: <20110721142920.GA5580@redhat.com> (raw)
In-Reply-To: <20110721125051.GA5443@albatros>
On 07/21, Vasiliy Kulikov wrote:
>
> On Wed, Jul 20, 2011 at 23:01 +0200, Oleg Nesterov wrote:
> >
> > Not sure I understand... This is not optimizing, the patch tries to
> > fix the unlikely (in fact mostly theoretical) and minor problem.
>
> Ah, I see the problem here. Yes, then it surely makes sense.
Yes, agreed.
Just in case... please note that "s->pid can be reused" doesn't
necessarily mean this pid was reused by kernel. For example, a
task can close the socket without DEREGISTER, then create another
one and do REGISTER which can race with send_cpu_listeners().
Afaics.
All this register/deregister logic doesn't look very right, imho.
> Reviewed-by: Vasiliy Kulikov <segoon@openwall.com>
Thanks,
Oleg.
next prev parent reply other threads:[~2011-07-21 14:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-20 18:59 [PATCH 0/2] 26c4caea "don't allow duplicate entries in listener mode" fix Oleg Nesterov
2011-07-20 19:00 ` [PATCH 1/2] taskstats: add_del_listener() shouldn't use the wrong node Oleg Nesterov
2011-07-20 19:50 ` Vasiliy Kulikov
2011-07-21 12:28 ` Jerome Marchand
2011-07-20 19:00 ` [PATCH 2/2] taskstats: add_del_listener() should ignore !valid listener's Oleg Nesterov
2011-07-20 19:46 ` Vasiliy Kulikov
2011-07-20 21:01 ` Oleg Nesterov
2011-07-21 12:50 ` Vasiliy Kulikov
2011-07-21 14:29 ` Oleg Nesterov [this message]
2011-07-21 15:49 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110721142920.GA5580@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bsingharora@gmail.com \
--cc=jmarchan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=segoon@openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.