All of lore.kernel.org
 help / color / mirror / Atom feed
From: Karel Zak <kzak@redhat.com>
To: "Voelker, Bernhard" <bernhard.voelker@siemens-enterprise.com>
Cc: "util-linux@vger.kernel.org" <util-linux@vger.kernel.org>
Subject: Re: ionice: requires scheduling since 7ab08ba3e5e6f161b93ff2b3b7d5b18dc7b44510
Date: Fri, 22 Jul 2011 12:57:30 +0200	[thread overview]
Message-ID: <20110722105730.GT22568@nb.net.home> (raw)
In-Reply-To: <7856072A9D04C24B82DFE2B1112FE38A08FE2D3B4F@MCHP058A.global-ad.net>

On Fri, Jul 22, 2011 at 12:21:08PM +0200, Voelker, Bernhard wrote:
> Karel Zak wrote:
> 
> > Fixed.
> > 
> >  I've also added support for human readable class names, you can use:
> > 
> >    ionice -c best-effort /bin/foo
> 
> great, thanks!
> 
> One last corner case regarding -t (ignoring failure):
> 
>   $ schedutils/ionice -c 4 -t  schedutils/ionice 
>   ionice: bad prio class 4
>   $ schedutils/ionice -n 8 -t  schedutils/ionice 
>   idle
> 
> With -c, a bad prio class leads to a failure, while it doesn't with -n.
> Is this intended?

OK. Copy & past from the latest commit:

    ionice: make -t more tolerant
    
    * replace errx() with warnx() for unknown -c class
    
      The right place to check I/O scheduler features is in kernel. We should
      not try to be more smart than kernel.
    
    * make the code ready (robust) for unknown sched.classes
    
    * fix -t behavior
    
    	old version:
    	  $ ionice -c 4 -t bash
    	  ionice: bad prio class 4
    
    	new version:
    	  $ ionice -c 4 -t bash
    
    Reported-by: Voelker, Bernhard" <bernhard.voelker@siemens-enterprise.com>
    Signed-off-by: Karel Zak <kzak@redhat.com>

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

      reply	other threads:[~2011-07-22 10:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-22  8:09 ionice: requires scheduling since 7ab08ba3e5e6f161b93ff2b3b7d5b18dc7b44510 Voelker, Bernhard
2011-07-22  8:54 ` Karel Zak
2011-07-22  8:57   ` Voelker, Bernhard
2011-07-22  9:43     ` Karel Zak
2011-07-22 10:21       ` Voelker, Bernhard
2011-07-22 10:57         ` Karel Zak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110722105730.GT22568@nb.net.home \
    --to=kzak@redhat.com \
    --cc=bernhard.voelker@siemens-enterprise.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.