All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: "Stephen M. Cameron" <scameron@beardog.cce.hp.com>
Cc: axboe@kernel.dk, stephenmcameron@gmail.com,
	mikem@beardog.cce.hp.com, linux-kernel@vger.kernel.org,
	thenzl@redhat.com, stable@kernel.org
Subject: Re: [PATCH] cciss: do not attempt to read from a write-only register
Date: Fri, 22 Jul 2011 15:39:19 -0700	[thread overview]
Message-ID: <20110722153919.ff53e0ae.akpm@linux-foundation.org> (raw)
In-Reply-To: <20110721181601.31646.18252.stgit@beardog.cce.hp.com>

On Thu, 21 Jul 2011 13:16:01 -0500
"Stephen M. Cameron" <scameron@beardog.cce.hp.com> wrote:

> From: Stephen M. Cameron <scameron@beardog.cce.hp.com>
> 
> Most smartarrays will tolerate it, but some new ones don't.
> Without this change some newer Smart Arrays will lock up
> and i/o will grind to a halt.
> 
> Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>

No Cc: <stable@kernel.org>?

>  drivers/block/cciss.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/block/cciss.h b/drivers/block/cciss.h
> index 16b4d58..c049548 100644
> --- a/drivers/block/cciss.h
> +++ b/drivers/block/cciss.h
> @@ -223,7 +223,7 @@ static void SA5_submit_command( ctlr_info_t *h, CommandList_struct *c)
>  			h->ctlr, c->busaddr);
>  #endif /* CCISS_DEBUG */
>           writel(c->busaddr, h->vaddr + SA5_REQUEST_PORT_OFFSET);
> -	readl(h->vaddr + SA5_REQUEST_PORT_OFFSET);
> +	readl(h->vaddr + SA5_SCRATCHPAD_OFFSET);
>  	 h->commands_outstanding++;
>  	 if ( h->commands_outstanding > h->max_outstanding)
>  		h->max_outstanding = h->commands_outstanding;

  parent reply	other threads:[~2011-07-22 22:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-21 18:16 [PATCH] cciss: do not attempt to read from a write-only register Stephen M. Cameron
2011-07-21 18:17 ` Stephen Cameron
2011-07-22 22:39 ` Andrew Morton [this message]
2011-07-23 11:46   ` Jens Axboe
  -- strict thread matches above, loose matches on Subject: below --
2011-07-08 19:58 Stephen M. Cameron
2011-07-09  7:02 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110722153919.ff53e0ae.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikem@beardog.cce.hp.com \
    --cc=scameron@beardog.cce.hp.com \
    --cc=stable@kernel.org \
    --cc=stephenmcameron@gmail.com \
    --cc=thenzl@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.