All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fredrik Gustafsson <iveqy@iveqy.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Fredrik Gustafsson <iveqy@iveqy.com>,
	git@vger.kernel.org, jens.lehmann@web.de, hvoigt@hvoigt.net
Subject: Re: [RFC PATCH] Move git-dir for submodules
Date: Fri, 22 Jul 2011 21:02:23 +0200	[thread overview]
Message-ID: <20110722190223.GA27076@kolya> (raw)
In-Reply-To: <7vhb6f1ipp.fsf@alter.siamese.dyndns.org>

Thanks for the review. I'll send an updated series soon.

On Thu, Jul 21, 2011 at 01:28:50PM -0700, Junio C Hamano wrote:
> Is it really necessary to have an ugly
> loop to make things relative, though?
The path must be relative to allow the superproject to be moved
around.

> I wonder if we want a new option to "git rev-parse" so that we can say
> 
> 	git rev-parse --is-well-formed-git-dir init/.git
> 
> to perform these checks without exposing the implimentation detail.

How about using
(cd <repo>; git rev-parse --verify HEAD" >/dev/null)
instead?

Med vänliga hälsningar
Fredrik Gustafsson

  parent reply	other threads:[~2011-07-22 19:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-21 16:52 [RFC PATCH] Move git-dir for submodules Fredrik Gustafsson
2011-07-21 20:28 ` Junio C Hamano
2011-07-21 21:40   ` Phil Hord
2011-07-21 21:50     ` Phil Hord
2011-07-21 23:37       ` Junio C Hamano
2011-07-21 23:47         ` Junio C Hamano
2011-07-22 19:02   ` Fredrik Gustafsson [this message]
2011-07-22 20:30     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110722190223.GA27076@kolya \
    --to=iveqy@iveqy.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=hvoigt@hvoigt.net \
    --cc=jens.lehmann@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.