All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Christoph Hellwig <hch@lst.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Eric Van Hensbergen <ericvh@gmail.com>
Subject: Re: [PATCH 1/4] 9p: do no return 0 from ->check_acl without actually checking
Date: Sat, 23 Jul 2011 16:49:22 +0100	[thread overview]
Message-ID: <20110723154922.GG24703@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20110723153638.GA10887@lst.de>

On Sat, Jul 23, 2011 at 05:36:38PM +0200, Christoph Hellwig wrote:
> If we do not want to use ACLs we at least need to perform normal Unix
> permission checks.  From the comment I'm not quite sure that's what
> is intended, but if 0p wants to do permission checks entirely on the
> server it needs to do so in ->permission, not in ->check_acl.

I'd like ACK and comments on that from 9p folks...

  reply	other threads:[~2011-07-23 15:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-23 15:36 [PATCH 0/4] more ACL updates Christoph Hellwig
2011-07-23 15:36 ` [PATCH 1/4] 9p: do no return 0 from ->check_acl without actually checking Christoph Hellwig
2011-07-23 15:49   ` Al Viro [this message]
2011-07-25  6:40   ` Aneesh Kumar K.V
2011-07-23 15:36 ` [PATCH 2/4] xfs: cache negative ACLs if there is no attribute fork Christoph Hellwig
2011-07-23 15:37 ` [PATCH 3/4] reiserfs: cache negative ACLs for v1 stat format Christoph Hellwig
2011-07-23 15:37 ` [PATCH 4/4] fs: take the ACL checks to common code Christoph Hellwig
2011-07-23 15:56   ` Linus Torvalds
2011-07-23 16:00     ` Christoph Hellwig
2011-07-23 16:15       ` Al Viro
2011-07-24 13:07         ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110723154922.GG24703@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=ericvh@gmail.com \
    --cc=hch@lst.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.