From: Kyungmin Park <kmpark@infradead.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] block: use the logical OR condition at blk_flush_complete_seq
Date: Mon, 25 Jul 2011 20:03:19 +0900 [thread overview]
Message-ID: <20110725110319.GA31362@july> (raw)
From: Kyungmin Park <kyungmin.park@samsung.com>
Even though the meaning is same, use the logical OR condition instead ORing.
seq blk_kick_flush(q) queued
1 1 0 => true
2 0 1 => true
8 0 0 => false
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
diff --git a/block/blk-flush.c b/block/blk-flush.c
index bb21e4c..66e0acb 100644
--- a/block/blk-flush.c
+++ b/block/blk-flush.c
@@ -187,7 +187,7 @@ static bool blk_flush_complete_seq(struct request *rq, unsigned int seq,
BUG();
}
- return blk_kick_flush(q) | queued;
+ return blk_kick_flush(q) || queued;
}
static void flush_end_io(struct request *flush_rq, int error)
reply other threads:[~2011-07-25 11:03 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110725110319.GA31362@july \
--to=kmpark@infradead.org \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.