From: Christoph Hellwig <hch@infradead.org>
To: Wang Sheng-Hui <shhuiw@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Jan Kara <jack@suse.cz>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] jbd: change the field "b_cow_tid" of struct journal_head from type unsigned to tid_t
Date: Mon, 25 Jul 2011 09:44:42 -0400 [thread overview]
Message-ID: <20110725134442.GA9826@infradead.org> (raw)
In-Reply-To: <4E2D6961.9000909@gmail.com>
On Mon, Jul 25, 2011 at 09:02:25PM +0800, Wang Sheng-Hui wrote:
> The patch is against 3.0
>
> In the definition of struct journal_head, the comment for
> the field "unsigned b_cow_tid" says the field tracks the
> last transaction id in which this buffer has been cowed.
The correct fix is to simply remove the field, as it's entirely unused.
next prev parent reply other threads:[~2011-07-25 13:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-25 13:02 [PATCH] jbd: change the field "b_cow_tid" of struct journal_head from type unsigned to tid_t Wang Sheng-Hui
2011-07-25 13:25 ` Amir Goldstein
2011-07-25 13:25 ` Amir Goldstein
2011-07-25 13:44 ` Christoph Hellwig [this message]
2011-07-25 14:19 ` Amir Goldstein
2011-07-25 15:31 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110725134442.GA9826@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shhuiw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.