From: Johan Hedberg <johan.hedberg@intel.com>
To: zheng wu <wu.zheng@intel.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] fixing crash in irmc.c when vcard=0
Date: Tue, 26 Jul 2011 12:29:09 +0300 [thread overview]
Message-ID: <20110726092909.GB28891@dell> (raw)
In-Reply-To: <1310714442-14565-1-git-send-email-wu.zheng@intel.com>
Hi,
On Fri, Jul 15, 2011, zheng wu wrote:
> When using sync profile, if getting the number of vcard is 0 in server,obexd will crash.
> The reason is that the null point is used in query_result of irmc.c.The patch is for fixing it.
> Signed-off-by: wu.zheng@intel.com
> ---
> plugins/irmc.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
The patch itself seems ok to me, but you need to fix your git settings:
1. Don't use Signed-off-by (this is only used for kernel patches).
2. Format your commit message lines to max 72 characters
3. Fix your git author name (first letter capitalized, etc.)
Johan
next prev parent reply other threads:[~2011-07-26 9:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-15 7:20 [PATCH] fixing crash in irmc.c when vcard=0 zheng wu
2011-07-26 9:29 ` Johan Hedberg [this message]
2011-07-27 3:05 ` Zheng, Wu
-- strict thread matches above, loose matches on Subject: below --
2011-07-27 3:05 Zheng Wu
2011-07-27 7:55 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110726092909.GB28891@dell \
--to=johan.hedberg@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=wu.zheng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.