From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753266Ab1GZJtQ (ORCPT ); Tue, 26 Jul 2011 05:49:16 -0400 Received: from 173-166-109-252-newengland.hfc.comcastbusiness.net ([173.166.109.252]:34250 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750900Ab1GZJtF (ORCPT ); Tue, 26 Jul 2011 05:49:05 -0400 Date: Tue, 26 Jul 2011 05:49:01 -0400 From: Christoph Hellwig To: Markus Trippelsdorf Cc: Christoph Hellwig , Steven Liu , Linus Torvalds , Al Viro , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] xfs: Fix build breakage in xfs_iops.c when CONFIG_FS_POSIX_ACL is not set Message-ID: <20110726094901.GA18893@infradead.org> References: <20110725185649.GA22133@ZenIV.linux.org.uk> <20110726033535.GA11939@x4.trippels.de> <20110726082146.GB11939@x4.trippels.de> <20110726085804.GA1639@x4.trippels.de> <20110726091520.GB1639@x4.trippels.de> <20110726093401.GA8334@infradead.org> <20110726094728.GA1629@x4.trippels.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110726094728.GA1629@x4.trippels.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 26, 2011 at 11:47:28AM +0200, Markus Trippelsdorf wrote: > No, "# CONFIG_OPTIMIZE_INLINING is not set". > I've tested this patch with gcc 4.5.2, 4.6.1 and 4.7.0 and in all cases > the kernel builds just fine. In that case we might as well just throw it in and try it. In the worst case we'll get one expansion per site that takes the address, but no-acl builds aren't really something worth optimizing for.