From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Liam Girdwood <lrg@ti.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [PATCH] ASoC: core - make IO calls return a valid errno on failure.
Date: Tue, 26 Jul 2011 12:43:21 +0100 [thread overview]
Message-ID: <20110726114321.GE7285@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1311679099.4088.6.camel@CNA0741383>
On Tue, Jul 26, 2011 at 12:18:19PM +0100, Liam Girdwood wrote:
> On Mon, 2011-07-25 at 23:22 +0200, Mark Brown wrote:
> > Yeah, it really should but it's kind of tricky for the reads as we're
> > returning errors in band and we could have 32 bit registers (I'm
> > guessing the platform versions already do) so we lose. :/ Not sure
> > what the best thing to do there is, changing to return the errors out of
> > band for reads is more painful than I care to contemplate.
> Oh, I agree it would be painful for a rework here. But why did you
> suggest this sort of update in a previous patch comment ? (Unless I
> misunderstood).
Dunno the specific posting but there's two things I can think of:
- This isn't an issue for writes so they can and should pass back error
codes, it's only reads that have trouble.
- If I see people converting an error code into -EINVAL or something I
tend to complain about that.
prev parent reply other threads:[~2011-07-26 11:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-25 10:15 [PATCH] ASoC: core - make IO calls return a valid errno on failure Liam Girdwood
2011-07-25 21:22 ` Mark Brown
2011-07-26 11:18 ` Liam Girdwood
2011-07-26 11:43 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110726114321.GE7285@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.