From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:44961) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QlhNU-0000L5-9m for qemu-devel@nongnu.org; Tue, 26 Jul 2011 09:08:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QlhNT-0004L5-9A for qemu-devel@nongnu.org; Tue, 26 Jul 2011 09:08:52 -0400 Received: from verein.lst.de ([213.95.11.211]:59887 helo=newverein.lst.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QlhNT-0004Id-4Z for qemu-devel@nongnu.org; Tue, 26 Jul 2011 09:08:51 -0400 Date: Tue, 26 Jul 2011 15:08:35 +0200 From: Christoph Hellwig Message-ID: <20110726130835.GL2853@lst.de> References: <1311179069-27882-1-git-send-email-armbru@redhat.com> <1311179069-27882-56-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1311179069-27882-56-git-send-email-armbru@redhat.com> Subject: Re: [Qemu-devel] [PATCH 55/55] ide/atapi scsi-disk: Make monitor eject -f, then change work List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, stefano.stabellini@eu.citrix.com, dbaryshkov@gmail.com, quintela@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, amit.shah@redhat.com On Wed, Jul 20, 2011 at 06:24:29PM +0200, Markus Armbruster wrote: > change fails while the tray is locked by the guest. eject -f forces > it open and removes any media. Unfortunately, the tray closes again > instantly. Since the lock remains as it is, there is no way to insert > another medium unless the guest voluntarily unlocks. > > Fix by leaving the tray open after monitor eject. Looks fine, Reviewed-by: Christoph Hellwig