From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:56903) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QljaI-0007Tv-AS for qemu-devel@nongnu.org; Tue, 26 Jul 2011 11:30:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QljaH-0007ka-3e for qemu-devel@nongnu.org; Tue, 26 Jul 2011 11:30:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11067) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QljaG-0007kV-Pv for qemu-devel@nongnu.org; Tue, 26 Jul 2011 11:30:13 -0400 Date: Tue, 26 Jul 2011 16:29:45 +0100 From: "Daniel P. Berrange" Message-ID: <20110726152945.GI19481@redhat.com> References: <1308832303-24205-1-git-send-email-berrange@redhat.com> <1308832303-24205-3-git-send-email-berrange@redhat.com> <4E2EDB30.1010804@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <4E2EDB30.1010804@adacore.com> Subject: Re: [Qemu-devel] [PATCH 2/3] Introduce a 'client_add' monitor command accepting an open FD Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fabien Chouteau Cc: qemu-devel@nongnu.org On Tue, Jul 26, 2011 at 05:20:16PM +0200, Fabien Chouteau wrote: > On 23/06/2011 14:31, Daniel P. Berrange wrote: > > Allow client connections for VNC and socket based character > > devices to be passed in over the monitor using SCM_RIGHTS. > > > > Hello Daniel, > > I'm a little bit late but it seems that there's a build error with this patch > when VNC is disabled. > > $./configure --target-list=ppc-softmmu --disable-vnc > ... > $ make > ... > monitor.o: In function `add_graphics_client': > .../monitor.c:1205: undefined reference to `vnc_display_add_client' There was already a patch posted yesterday which should fix this problem: Subject: [PATCH] monitor: fix build breakage with --disable-vnc Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|