From: Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
To: Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
Zeng Zhaoming
<zhaoming.zeng-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
Liam Girdwood <lrg-l0cyMroinI0@public.gmane.org>
Subject: Re: [PATCH] ASoC: sgtl5000: add device tree probe support
Date: Tue, 26 Jul 2011 20:55:11 +0100 [thread overview]
Message-ID: <20110726195511.GA9956@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1311265731-23318-1-git-send-email-shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
On Fri, Jul 22, 2011 at 12:28:51AM +0800, Shawn Guo wrote:
> It adds device tree probe support for sgtl5000 driver.
Kind of waiting for the device tree people to comment on this...
> .../bindings/sound/soc/codecs/fsl-sgtl5000.txt | 11 +++++++++++
I'd expect this can just be put directly under the sound directory.
> +++ b/Documentation/devicetree/bindings/sound/soc/codecs/fsl-sgtl5000.txt
> @@ -0,0 +1,11 @@
> +* Freescale SGTL5000 Stereo Codec
> +
> +Required properties:
> +- compatible : "fsl,sgtl5000".
> +
> +Example:
> +
> +codec: sgtl5000@0a {
> + compatible = "fsl,sgtl5000";
> + reg = <0x0a>;
> +};
This might get a tiny bit verbose... I wonder if it makes sense to have
some central file for devices with trivial bindings? But possibly more
trouble than it's worth.
next prev parent reply other threads:[~2011-07-26 19:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-21 16:28 [PATCH] ASoC: sgtl5000: add device tree probe support Shawn Guo
[not found] ` <1311265731-23318-1-git-send-email-shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2011-07-26 19:55 ` Mark Brown [this message]
2011-07-29 2:40 ` Shawn Guo
2011-07-29 16:00 ` Grant Likely
2011-07-29 16:00 ` Grant Likely
2011-07-29 16:37 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110726195511.GA9956@opensource.wolfsonmicro.com \
--to=broonie-yzvpicuk2aatku/dhu1wvuem+bqzidxxqq4iyu8u01e@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=lrg-l0cyMroinI0@public.gmane.org \
--cc=patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=zhaoming.zeng-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.