From: "Ted Ts'o" <tytso@mit.edu>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Al Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
Josef Bacik <josef@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PULL REQUEST] ext3, jbd, ext2, and quota fixes for 3.1-rc1
Date: Tue, 26 Jul 2011 20:31:08 -0400 [thread overview]
Message-ID: <20110727003108.GA19851@thunk.org> (raw)
In-Reply-To: <CA+55aFyCs3T_BhwjhW=zC9+5G7tnUNmQAa+77YndJ9BuV4Kbig@mail.gmail.com>
On Tue, Jul 26, 2011 at 12:14:28PM -0700, Linus Torvalds wrote:
> On Tue, Jul 26, 2011 at 11:59 AM, Christoph Hellwig <hch@infradead.org> wrote:
> >
> > In addition to beeing bogus the code also is useless. fsync on a file
> > explicitly does not guarantee anything at all about the parent, and
> > never really has on Linux either.
>
> Well, it may never have done that, but it might still be a case of
> quality-of-implementation.
>
> The data blocks and inode indirect blocks being stable on disk doesn't
> help hugely if you cannnot actually reach the inode itself.
Yeah, that's why it was done. Frank found that with power-fail
testing, a large number of files that were freshly created and then
fsync()'ed would disappear. If the data is supposed to be available
after a power failure, then you have to be able to get to it somehow.
I agree what's there isn't safe, and needs to be fixed. I'll deal
with it.
- Ted
next prev parent reply other threads:[~2011-07-27 0:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-26 18:14 [PULL REQUEST] ext3, jbd, ext2, and quota fixes for 3.1-rc1 Jan Kara
2011-07-26 18:36 ` Linus Torvalds
2011-07-26 18:36 ` Linus Torvalds
2011-07-26 18:52 ` Al Viro
2011-07-26 18:59 ` Christoph Hellwig
2011-07-26 19:14 ` Linus Torvalds
2011-07-26 19:14 ` Linus Torvalds
2011-07-27 0:31 ` Ted Ts'o [this message]
2011-07-26 20:16 ` Jan Kara
2011-07-26 20:10 ` Jan Kara
2011-07-26 20:10 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110727003108.GA19851@thunk.org \
--to=tytso@mit.edu \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=josef@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.