From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:54176)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Qm06K-00050V-Ab
	for qemu-devel@nongnu.org; Wed, 27 Jul 2011 05:08:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Qm06J-0005kV-AR
	for qemu-devel@nongnu.org; Wed, 27 Jul 2011 05:08:24 -0400
Received: from mx1.redhat.com ([209.132.183.28]:41256)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Qm06J-0005kO-22
	for qemu-devel@nongnu.org; Wed, 27 Jul 2011 05:08:23 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6R98MBN008297
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 27 Jul 2011 05:08:22 -0400
Date: Wed, 27 Jul 2011 12:08:52 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20110727090852.GB31946@redhat.com>
References: <cover.1311755243.git.amit.shah@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cover.1311755243.git.amit.shah@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/4] Fix virtio memleaks
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu list <qemu-devel@nongnu.org>, Markus Armbruster <armbru@redhat.com>

On Wed, Jul 27, 2011 at 02:00:28PM +0530, Amit Shah wrote:
> The memory allocated in virtio_common_init() wasn't being freed
> anywhere.  Fix that.
> 
> The balloon handler wasn't unregistering its savevm section,
> adding an exit handler fixes that as well.
> 
> This patchset is on top of the two balloon series I've sent out
> yesterday and today.

This looks good to me. What do you say I put
patches 2-4 on my tree, and you put patch 1 on yours?

> Amit Shah (4):
>   virtio-balloon: Add exit handler, fix memleaks
>   virtio-blk: Fix memleak on exit
>   virtio-net: Fix potential use-after-free
>   virtio: Plug memleak by freeing vdev
> 
>  hw/virtio-balloon.c |    9 +++++++++
>  hw/virtio-blk.c     |    1 +
>  hw/virtio-net.c     |    2 +-
>  hw/virtio-pci.c     |   11 ++++++++++-
>  hw/virtio.c         |    1 +
>  hw/virtio.h         |    1 +
>  6 files changed, 23 insertions(+), 2 deletions(-)
> 
> -- 
> 1.7.6
>