From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:44537) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qm28W-0001tn-Aj for qemu-devel@nongnu.org; Wed, 27 Jul 2011 07:18:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qm28V-0007xk-8r for qemu-devel@nongnu.org; Wed, 27 Jul 2011 07:18:48 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:53730) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qm28U-0007xY-Uc for qemu-devel@nongnu.org; Wed, 27 Jul 2011 07:18:47 -0400 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e39.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p6RB3tww019930 for ; Wed, 27 Jul 2011 05:03:55 -0600 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id p6RBIjfX199584 for ; Wed, 27 Jul 2011 05:18:45 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p6R5IifP004731 for ; Tue, 26 Jul 2011 23:18:45 -0600 From: Supriya Kannery Date: Wed, 27 Jul 2011 17:00:27 +0530 Message-Id: <20110727113027.25109.33096.sendpatchset@skannery> In-Reply-To: <20110727113000.25109.16204.sendpatchset@skannery> References: <20110727113000.25109.16204.sendpatchset@skannery> Subject: [Qemu-devel] [V5 Patch 2/4]Qemu: qerrors for file reopen, data sync and cmd syntax List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi , Christoph Hellwig , Supriya Kannery New error classes defined for file reopen failure, data sync error and incorrect command syntax Signed-off-by: Supriya Kannery --- qerror.c | 12 ++++++++++++ qerror.h | 8 ++++++++ 2 files changed, 20 insertions(+) Index: qemu/qerror.c =================================================================== --- qemu.orig/qerror.c +++ qemu/qerror.c @@ -97,6 +97,14 @@ static const QErrorStringTable qerror_ta .desc = "Device '%(device)' is not removable", }, { + .error_fmt = QERR_DATA_SYNC_FAILED, + .desc = "Syncing of data failed for device '%(device)'", + }, + { + .error_fmt = QERR_REOPEN_FILE_FAILED, + .desc = "Could not reopen '%(filename)'", + }, + { .error_fmt = QERR_DEVICE_NO_BUS, .desc = "Device '%(device)' has no child bus", }, @@ -230,6 +238,10 @@ static const QErrorStringTable qerror_ta .error_fmt = QERR_QGA_COMMAND_FAILED, .desc = "Guest agent command failed, error was '%(message)'", }, + { + .error_fmt = QERR_INCORRECT_COMMAND_SYNTAX, + .desc = "Usage: %(syntax)", + }, {} }; Index: qemu/qerror.h =================================================================== --- qemu.orig/qerror.h +++ qemu/qerror.h @@ -85,6 +85,9 @@ QError *qobject_to_qerror(const QObject #define QERR_DEVICE_NOT_FOUND \ "{ 'class': 'DeviceNotFound', 'data': { 'device': %s } }" +#define QERR_DATA_SYNC_FAILED \ + "{ 'class': 'DataSyncFailed', 'data': { 'device': %s } }" + #define QERR_DEVICE_NOT_REMOVABLE \ "{ 'class': 'DeviceNotRemovable', 'data': { 'device': %s } }" @@ -142,6 +145,9 @@ QError *qobject_to_qerror(const QObject #define QERR_OPEN_FILE_FAILED \ "{ 'class': 'OpenFileFailed', 'data': { 'filename': %s } }" +#define QERR_REOPEN_FILE_FAILED \ + "{ 'class': 'ReopenFileFailed', 'data': { 'filename': %s } }" + #define QERR_PROPERTY_NOT_FOUND \ "{ 'class': 'PropertyNotFound', 'data': { 'device': %s, 'property': %s } }" @@ -193,4 +199,6 @@ QError *qobject_to_qerror(const QObject #define QERR_QGA_COMMAND_FAILED \ "{ 'class': 'QgaCommandFailed', 'data': { 'message': %s } }" +#define QERR_INCORRECT_COMMAND_SYNTAX \ + "{ 'class': 'IncorrectCommandSyntax', 'data': { 'syntax': %s } }" #endif /* QERROR_H */